From owner-svn-ports-head@freebsd.org Tue Sep 27 21:51:02 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03FF2BEAB6A; Tue, 27 Sep 2016 21:51:02 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D363B16C3; Tue, 27 Sep 2016 21:51:01 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [127.0.0.1] (ip70-178-28-115.ks.ks.cox.net [70.178.28.115]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 96A3E43BF0; Tue, 27 Sep 2016 16:50:47 -0500 (CDT) Subject: Re: svn commit: r422826 - head/security/libsodium To: Mathieu Arnold , marino@freebsd.org, Vsevolod Stakhov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201609271943.u8RJhXe0061946@repo.freebsd.org> <6d763b2f-0745-9f7a-c94e-b9653174bdd5@marino.st> Reply-To: marino@freebsd.org From: John Marino Message-ID: Date: Tue, 27 Sep 2016 16:50:58 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Antivirus: avast! (VPS 160927-2, 09/27/2016), Outbound message X-Antivirus-Status: Clean X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2016 21:51:02 -0000 On 9/27/2016 16:14, Mathieu Arnold wrote: > Le 27/09/2016 à 21:51, John Marino a écrit : >> On 9/27/2016 14:43, Vsevolod Stakhov wrote: >>> Author: vsevolod >>> Date: Tue Sep 27 19:43:32 2016 >>> New Revision: 422826 >>> URL: https://svnweb.freebsd.org/changeset/ports/422826 >>> >>> Log: >>> - Update to 1.0.11 >>> >>> No bump for dependent port is required as this version has no API >>> changes >>> >>> >>> Modified: head/security/libsodium/pkg-plist >>> ============================================================================== >>> >>> --- head/security/libsodium/pkg-plist Tue Sep 27 18:25:34 2016 >>> (r422825) >>> +++ head/security/libsodium/pkg-plist Tue Sep 27 19:43:32 2016 >>> (r422826) >>> @@ -58,7 +58,7 @@ include/sodium/version.h >>> lib/libsodium.a >>> lib/libsodium.so >>> lib/libsodium.so.18 >>> -lib/libsodium.so.18.1.0 >>> +lib/libsodium.so.18.1.1 >>> libdata/pkgconfig/libsodium.pc >>> %%PORTDOCS%%%%DOCSDIR%%/AUTHORS >>> %%PORTDOCS%%%%DOCSDIR%%/README.markdown >>> >> >> First, I don't think the "no API change" means a bump is not mandatory. >> Secondly, the SO name of the library changed!!! You have to bump it, >> there's no question here. >> >> It's 1000x better to bump unnecessarily than to skip a bump that is >> required. > > No it did not. > > $ readelf -d `make -V STAGEDIR`/usr/local/lib/libsodium.so|grep soname > 0x000000000000000e SONAME Library soname: [libsodium.so.18] > > The file name changed, but software will try to find libsodium.so.18, > and that will still work. > regardless, why should the bump be avoided? There could have been fixes against the existing functions. I'm starting to see a lot of people go out of their way to bump and I don't know where the trend is coming from. Is portmgr saying vsevolod is correct not to bump this? I would bump it and if that's wrong maybe my bump criteria is wrong. John --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus