From owner-freebsd-gnome@FreeBSD.ORG Sun Nov 13 14:16:34 2005 Return-Path: <owner-freebsd-gnome@FreeBSD.ORG> X-Original-To: gnome@freebsd.org Delivered-To: freebsd-gnome@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 54BBB16A41F; Sun, 13 Nov 2005 14:16:34 +0000 (GMT) (envelope-from girgen@FreeBSD.org) Received: from mxfep02.bredband.com (mxfep02.bredband.com [195.54.107.73]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B53143D45; Sun, 13 Nov 2005 14:16:25 +0000 (GMT) (envelope-from girgen@FreeBSD.org) Received: from ironport.bredband.com ([195.54.107.82] [195.54.107.82]) by mxfep02.bredband.com with ESMTP id <20051113141624.WOEA9142.mxfep02.bredband.com@ironport.bredband.com>; Sun, 13 Nov 2005 15:16:24 +0100 Received: from c-aec2e255.022-2016-73746f39.cust.bredbandsbolaget.se (HELO palle.girgensohn.se) ([85.226.194.174]) by ironport.bredband.com with ESMTP; 13 Nov 2005 15:15:48 +0100 X-BrightmailFiltered: true X-Brightmail-Tracker: AAAAAA== X-IronPort-AV: i="3.97,319,1125871200"; d="scan'208"; a="9732056:sNHT45924903" Received: from palle.girgensohn.se (palle.girgensohn.se [127.0.0.1]) by palle.girgensohn.se (Postfix) with ESMTP id C80A11731E; Sun, 13 Nov 2005 15:16:15 +0100 (CET) Date: Sun, 13 Nov 2005 15:16:15 +0100 From: Palle Girgensohn <girgen@FreeBSD.org> To: Andrey Chernov <ache@FreeBSD.ORG>, ports@FreeBSD.ORG, nork@FreeBSD.ORG Message-ID: <2CF7A824B038A3AC8E976809@palle.girgensohn.se> In-Reply-To: <20051113120157.GA42256@nagual.pp.ru> References: <200511130038.jAD0cgLb043746@sakura.ninth-nine.com> <20051113120157.GA42256@nagual.pp.ru> X-Mailer: Mulberry/3.1.6 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Mailman-Approved-At: Sun, 13 Nov 2005 17:49:15 +0000 Cc: yazzy@yazzy.org, kde@FreeBSD.ORG, ozawa@ongs.co.jp, hq@FreeBSD.ORG, ronald@cs.vu.nl, obrien@FreeBSD.ORG, bsam@ipt.ru, kirk@strauser.com, bzeeb+freebsdports@zabbadoz.net, tobez@FreeBSD.ORG, gnome@FreeBSD.ORG, bms@FreeBSD.ORG, osa@FreeBSD.ORG, freebsd@troback.com, shelton@granch.ru, green@FreeBSD.ORG, lev@FreeBSD.ORG, ahze@FreeBSD.ORG, nobutaka@FreeBSD.ORG, ale@FreeBSD.ORG, clement@FreeBSD.ORG, shoesoft@gmx.net, seanc@FreeBSD.ORG, lawrance@FreeBSD.ORG, simond@irrelevant.org, swhetzel@gmail.com, mezz@FreeBSD.ORG, 3d@FreeBSD.ORG, c47g@gmx.at, ehaupt@FreeBSD.ORG, mharo@FreeBSD.ORG, acardenas@bsd.org.pe, jonas@schiebtsich.net, weaseal@users.sourceforge.net, skv@FreeBSD.ORG, kwm@FreeBSD.ORG, jura@netams.com, sem@FreeBSD.ORG, novel@FreeBSD.ORG, vsevolod@FreeBSD.ORG, danny@ricin.com, phantom@FreeBSD.ORG, shetuhin@corp.mail.ru, gerald@FreeBSD.ORG, roam@FreeBSD.ORG, taguchi@tohoku.iij.ad.jp, alecn2002@yandex.ru, vivek@khera.org, joerg@FreeBSD.ORG, neal@nelson.name, mva@sysfault.org, garga@FreeBSD.ORG, anrays@gmail.com, barner@FreeBSD.ORG, mnag@FreeBSD.ORG, riggs@rrr.de, glewis@FreeBSD.ORG, freebsd@jdc.parodius.com Subject: Re: Integrated DEBUG related macros to WITH_DEBUG/WITHOUT_DEBUG X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining <freebsd-gnome.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>, <mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome> List-Post: <mailto:freebsd-gnome@freebsd.org> List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>, <mailto:freebsd-gnome-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sun, 13 Nov 2005 14:16:34 -0000 --On s=F6ndag, november 13, 2005 15.01.58 +0300 Andrey Chernov=20 <ache@FreeBSD.ORG> wrote: > On Sun, Nov 13, 2005 at 09:38:42AM +0900, Norikatsu Shigemura wrote: >> Hi ports maintainers! >> >> I consider that DEBUG related knob should be integrated >> to WITH_DEBUG/WITHOUT_DEBUG. So I want to add DEBUG to >> /usr/ports/KNOBS. But following ports should be modified. >> How about do you think? >> >> ok: using WITH_DEBUG/WITHOUT_DEBUG >> ok? using *_DEBUG_* knobs. But I think that these should not >> be replaced to WITH_DEBUG. Semantics different. >> ng: using *DEBUG* knobs. I think that these should be replaced >> to WITH_DEBUG/WITHOUT_DEBUG. > > *DEBUG knob has different meaning from port to port and often not just -g > adding, but turns on internal port debugging output/checks. -g should really be honored through CFLAGS? I don't think that adding -g=20 alone alone calls for the need for a DEBUG knob, it must be the internal=20 port debugging checks we want by using the knob, right? > It means that it should be turned on/off separately on per port basis. > I.e. WITH_<portname>_DEBUG. > > WITH_<portname>_* style options also allows to add them all into > /etc/make.conf without creating name conflicts between the ports.