Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 Jul 2023 13:46:20 GMT
From:      Joseph Mingrone <jrm@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 181692ab0896 - main - pw: Add regression tests for useradd bug fixes
Message-ID:  <202307191346.36JDkK7W050982@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by jrm:

URL: https://cgit.FreeBSD.org/src/commit/?id=181692ab0896637bc174ab3e1ef319991dfa371f

commit 181692ab0896637bc174ab3e1ef319991dfa371f
Author:     Naman Sood <mail@nsood.in>
AuthorDate: 2023-07-19 13:27:14 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2023-07-19 13:43:12 +0000

    pw: Add regression tests for useradd bug fixes
    
    PR:             238995
    Reviewed by:    jrm
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D41080
---
 usr.sbin/pw/tests/pw_useradd_test.sh | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/usr.sbin/pw/tests/pw_useradd_test.sh b/usr.sbin/pw/tests/pw_useradd_test.sh
index e9d0a3aa20af..ac24b0df6693 100755
--- a/usr.sbin/pw/tests/pw_useradd_test.sh
+++ b/usr.sbin/pw/tests/pw_useradd_test.sh
@@ -463,6 +463,29 @@ user_add_conf_defaultpasswd_body()
 	    grep defaultpasswd ${HOME}/pw.conf
 }
 
+atf_test_case user_add_existing_login_group
+user_add_existing_login_group_body()
+{
+	populate_etc_skel
+
+	atf_check -s exit:0 ${PW} groupadd testuser
+	atf_check -s exit:0 ${PW} useradd user1 -G testuser
+	atf_check -s exit:0 ${PW} useradd testuser
+	atf_check -o match:"1" \
+	    sh -c "grep testuser ${HOME}/group | wc -l"
+}
+
+atf_test_case user_add_already_in_group
+user_add_already_in_group_body()
+{
+	populate_etc_skel
+
+	echo "testgroup:*:4242:testuser" >> ${HOME}/group
+	atf_check -s exit:0 ${PW} useradd testuser -G testgroup
+	atf_check -o not-match:"testuser,testuser" \
+		grep testuser ${HOME}/group
+}
+
 atf_init_test_cases() {
 	atf_add_test_case user_add
 	atf_add_test_case user_add_noupdate
@@ -503,4 +526,6 @@ atf_init_test_cases() {
 	atf_add_test_case user_add_defaultgroup
 
 	atf_add_test_case user_add_conf_defaultpasswd
+	atf_add_test_case user_add_existing_login_group
+	atf_add_test_case user_add_already_in_group
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202307191346.36JDkK7W050982>