From owner-freebsd-usb@FreeBSD.ORG Thu Mar 22 15:50:08 2007 Return-Path: X-Original-To: freebsd-usb@hub.freebsd.org Delivered-To: freebsd-usb@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 40C0116A40A for ; Thu, 22 Mar 2007 15:50:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id CDA0D13C4EA for ; Thu, 22 Mar 2007 15:50:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l2MFo40O048899 for ; Thu, 22 Mar 2007 15:50:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l2MFo42R048898; Thu, 22 Mar 2007 15:50:04 GMT (envelope-from gnats) Resent-Date: Thu, 22 Mar 2007 15:50:04 GMT Resent-Message-Id: <200703221550.l2MFo42R048898@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-usb@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, URATAN Shigenobu Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B796C16A406 for ; Thu, 22 Mar 2007 15:42:38 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [69.147.83.33]) by mx1.freebsd.org (Postfix) with ESMTP id A911413C48C for ; Thu, 22 Mar 2007 15:42:38 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l2MFgc5C013968 for ; Thu, 22 Mar 2007 15:42:38 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id l2MFbang013073; Thu, 22 Mar 2007 15:37:36 GMT (envelope-from nobody) Message-Id: <200703221537.l2MFbang013073@www.freebsd.org> Date: Thu, 22 Mar 2007 15:37:36 GMT From: URATAN Shigenobu To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.0 Cc: Subject: usb/110681: [ukbd][patch] multiple keys will be repeated X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2007 15:50:08 -0000 >Number: 110681 >Category: usb >Synopsis: [ukbd][patch] multiple keys will be repeated >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-usb >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Mar 22 15:50:04 GMT 2007 >Closed-Date: >Last-Modified: >Originator: URATAN Shigenobu >Release: 6.2-RELEASE >Organization: personal >Environment: FreeBSD 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Fri Jan 12 10:40:27 UTC 2007 root@dessler.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: when using USB keyboard on syscons, and keep pressing multiple keys, all pressed keys will be repeated, like: "jjjjjjjjjjjjdjjjjjdjdjdjdjdjdjdjdjdjdjdjdjdjdjdjdjdjdjdjd" (expample: first press 'j', then press 'd') with the patch, only latest one key will be repeated. "jjjjjjjjjjjjdddddddddddddddddddddddddddddddddddddddddd" >How-To-Repeat: >Fix: Patch attached with submission follows: --- ukbd.c.orig Sun Oct 29 16:30:06 2006 +++ ukbd.c Fri Mar 23 00:20:35 2007 @@ -39,7 +39,7 @@ */ #include -__FBSDID("$FreeBSD: src/sys/dev/usb/ukbd.c,v 1.52.2.3 2006/10/29 07:30:06 ru Exp $"); +__FBSDID("$FreeBSD: src/sys/dev/usb/ukbd.c,v 1.52.2.3 2006/10/29 07:30:06 xx Exp $"); /* * HID spec: http://www.usb.org/developers/devclass_docs/HID1_11.pdf @@ -772,6 +772,16 @@ } } ADDKEY1(key | KEY_PRESS); + /* + * here, some key detected to be pressed, + * so kill repeat of all other keys. + * (postpone repeat trigger time 100sec from now) + */ + for(j=0; jks_ntime[j] = now + 100*1000; + } + pfound: ; } >Release-Note: >Audit-Trail: >Unformatted: