From owner-dev-commits-src-main@freebsd.org Thu May 6 17:39:39 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9AD04629203 for ; Thu, 6 May 2021 17:39:39 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FbgnR3RQHz4tY5 for ; Thu, 6 May 2021 17:39:39 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qk1-x736.google.com with SMTP id x8so5765077qkl.2 for ; Thu, 06 May 2021 10:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PW3GN0XN1zRQlMn2Ae4dC70S3Zm5SF/gzRpwzsnuGa8=; b=OJ7BJ7B/QYSrwdptaNZpwo8fU7M3hHeePg21wrQcI+cuf7JzafZs7vv3s+snzIBBsw 5EFo7JahWvvCgHtdhH0z4zmPUvfwzZNZof3tLc7JNN6lbW6eRxnNaajpLQmaswVU4zm3 +qrMGq3Up7l74JtiolqRAIs9Ni58jnjEDocWK949ouZagDZF9adlotQwxH8ARtcipuO2 y5g829jJBuCvDSXIfj5HjAEhuz4NaotWqiNfwPNNAK0hOuBsis/bTnk25aGogT6cwSCA AgnJIhq+cPjouR6+BdC6V4pSPsn3FafVtZt7tOtDVsfSrcl0+qmEgNULpT2Zz6jXeuKX PISA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PW3GN0XN1zRQlMn2Ae4dC70S3Zm5SF/gzRpwzsnuGa8=; b=frF1gJlawdzhosyoFPFvV7pPdmvfiFN9wLK4yQdkVX7gcLzRthQUSWs+iARgypoAHX P0t4IZwrXI9OijGvzXnYyeCHkjoBbMHUWlQ1MLQVFq0vQIe+GEdrzvUSizve+iQ8eAHX xJygudG+1IrC7dCQiUX32+qNX2OpHE+D+e4ITFCruIcDZ5efhAzho9thCjHRrLI/ARgZ vCpyDfBYMxZVpZxckz+db2IUB+4tJnU8oqukW0Ud6+Nro3hVFaSjH0868k3oR22gt+71 hJcTe+aw/+haFz/mK9D2rHGmzTwM3IbxnAJpmQgB+tU9aXrHdqdboQkJ7axLzbxJCrgZ 888g== X-Gm-Message-State: AOAM5302iexZZ1v4qh1+eSMY0BRBEB419smGnyt/UU1uvFAIP7bVBJP1 2EFhr9axo8vM5ifBjeVd4F2cyGHxKOKylu2r X-Google-Smtp-Source: ABdhPJyq7NK04kjtG1ePIiOh5gp6Jw+acF/tXrGNzoRUWa7bVwEFCZCLbIEfa/xqK9P9IPfpWNgGpg== X-Received: by 2002:ae9:f10b:: with SMTP id k11mr5338470qkg.62.1620322778490; Thu, 06 May 2021 10:39:38 -0700 (PDT) Received: from mutt-hbsd (pool-100-16-222-53.bltmmd.fios.verizon.net. [100.16.222.53]) by smtp.gmail.com with ESMTPSA id f7sm2986285qtm.41.2021.05.06.10.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 10:39:37 -0700 (PDT) Date: Thu, 6 May 2021 13:39:37 -0400 From: Shawn Webb To: Randall Stewart Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 5d8fd932e418 - main - This brings into sync FreeBSD with the netflix versions of rack and bbr. This fixes several breakages (panics) since the tcp_lro code was committed that have been reported. Quite a few new features are now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the largest). There is also support for ack-war prevention. Documents comming soon on rack.. Message-ID: <20210506173937.khuft4fuvztidkf3@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202105061526.146FQS0E008755@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u2yl6bpfqrkntlk5" Content-Disposition: inline In-Reply-To: <202105061526.146FQS0E008755@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4FbgnR3RQHz4tY5 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2021 17:39:39 -0000 --u2yl6bpfqrkntlk5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 06, 2021 at 03:26:28PM +0000, Randall Stewart wrote: > The branch main has been updated by rrs: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D5d8fd932e418f03e98b3469c40= 88a36f0ef34ffe >=20 > commit 5d8fd932e418f03e98b3469c4088a36f0ef34ffe > Author: Randall Stewart > AuthorDate: 2021-05-06 15:22:26 +0000 > Commit: Randall Stewart > CommitDate: 2021-05-06 15:22:26 +0000 >=20 > This brings into sync FreeBSD with the netflix versions of rack and b= br. > This fixes several breakages (panics) since the tcp_lro code was > committed that have been reported. Quite a few new features are > now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the > largest). There is also support for ack-war prevention. Documents > comming soon on rack.. > =20 > Sponsored by: Netflix > Reviewed by: rscheff, mtuexen > Differential Revision: https://reviews.freebsd.org/D30036 > --- > sys/netinet/cc/cc.h | 7 +- > sys/netinet/cc/cc_newreno.c | 34 +- > sys/netinet/cc/cc_newreno.h | 13 +- > sys/netinet/tcp.h | 24 +- > sys/netinet/tcp_accounting.h | 39 + > sys/netinet/tcp_input.c | 10 +- > sys/netinet/tcp_log_buf.h | 8 +- > sys/netinet/tcp_ratelimit.c | 29 +- > sys/netinet/tcp_ratelimit.h | 4 +- > sys/netinet/tcp_sack.c | 11 + > sys/netinet/tcp_stacks/bbr.c | 92 +- > sys/netinet/tcp_stacks/rack.c | 9876 ++++++++++++++++++++++--= ------ Hey Randall, Out of curiosity, did anyone take the time to audit/review the changes to rack.c? Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --u2yl6bpfqrkntlk5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmCUKdYACgkQ/y5nonf4 4fqASw//dqyYRZi4/PsnGz12e4XA6TSu1cczo0IHSc7kqNFv2Naq4mlM0+wLL3ke jibw5yU0FiRa0uglmoaTskigwbqNjm0zPQjGeJUvyCdoW6SbyJtWDvbjnNf8aqi2 xKnHlOvAWeFiQ3FUAsfK3LRvEC0eqUtV5dywxJ6vfVzi5O1pQr9m0steGc0+QLvo KvnF9vcQGSmaYGm4yPoufDXv3yWPek8MynsEJQeSmN0/I4+4fvERPKRVd1KQvEcB ittFDnCntPxgUG1JkWAE5KTsn1AfondEn/r/lYPIXjQJbTXf9MoHpPp6WukVhCnt fzwp0tLjPARQIv6DWuIOs3ngKOK3DdjxGsrO5n74tQtOtSeWUh9h06P6BPMa1Cn9 +sBhJSDE70ahcfCQE/vONZbCeX8tta18EXG3MmrhOJOsDBgeoPqTXxH1pV59Lqaw SMpfa7q7e/GcgblJSxOa5lpBXZmke1MYOtIaVtYzV2Ua1ee0ZqN5kRo+ccAKxsbU dQWvB9/b6qgNewmpOJgf/ljntuQUTbHGiszXokqju+3rFMZL3jFSWI/oknd8W2Ww W+r8iisXw8M8tEFwCOcMPF/rRG49xnwrcHASrejJZ/+nQm3iSvdlDisAGciHFVTC oUEHTU4+70FiQSesfV8JEbhP2U4h6tl+huZoTTU1BQfH1v/j5hI= =CQ+6 -----END PGP SIGNATURE----- --u2yl6bpfqrkntlk5--