From owner-freebsd-python@freebsd.org Fri Nov 15 03:27:17 2019 Return-Path: Delivered-To: freebsd-python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A27ED1BAFC6 for ; Fri, 15 Nov 2019 03:27:17 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 47DkLF3RmMz4BZB for ; Fri, 15 Nov 2019 03:27:17 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 72A5E1BAFC1; Fri, 15 Nov 2019 03:27:17 +0000 (UTC) Delivered-To: python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 720811BAFC0; Fri, 15 Nov 2019 03:27:17 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47DkLF2KmKz4BYw; Fri, 15 Nov 2019 03:27:17 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 2DF791CF97; Fri, 15 Nov 2019 03:27:17 +0000 (UTC) From: Jan Beich To: Kubilay Kocak Cc: Enji Cooper , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, python Subject: Re: svn commit: r517602 - head/devel/py-mock References: <201911141711.xAEHBwBO077712@repo.freebsd.org> <6f252ffe-9e8d-3bb7-fe48-baccda10012d@FreeBSD.org> Date: Fri, 15 Nov 2019 04:27:15 +0100 In-Reply-To: <6f252ffe-9e8d-3bb7-fe48-baccda10012d@FreeBSD.org> (Kubilay Kocak's message of "Fri, 15 Nov 2019 12:05:18 +1100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Nov 2019 03:27:17 -0000 Kubilay Kocak writes: > The canonical pytest invocation is: > > cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopts= For a canonical it is uncommon. Besides, you've made mistakes: - No braces around `cd` compared to what Porter's Handbook recommends - No TEST_ENV in case tests need TZ=UTC, LANG=en_US.UTF-8, etc.