From owner-svn-src-head@FreeBSD.ORG Tue Aug 25 08:33:55 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 61953106568C; Tue, 25 Aug 2009 08:33:55 +0000 (UTC) (envelope-from mitya@m4-new.master-telecom.ru) Received: from m4-new.master-telecom.ru (m4-new.master-telecom.ru [85.193.64.114]) by mx1.freebsd.org (Postfix) with ESMTP id AD2918FC20; Tue, 25 Aug 2009 08:33:54 +0000 (UTC) Received: from m4-new.master-telecom.ru (localhost [127.0.0.1]) by m4-new.master-telecom.ru (8.13.8/8.13.8) with ESMTP id n7P7xXux078835; Tue, 25 Aug 2009 11:59:33 +0400 (MSD) (envelope-from mitya@m4-new.master-telecom.ru) Received: (from mitya@localhost) by m4-new.master-telecom.ru (8.13.8/8.13.8/Submit) id n7P7xUWX078830; Tue, 25 Aug 2009 11:59:30 +0400 (MSD) (envelope-from mitya) Date: Tue, 25 Aug 2009 11:59:30 +0400 From: Dmitry Sivachenko To: Pyun YongHyeon Message-ID: <20090825075930.GA77905@m4-new.master-telecom.ru> References: <200902271925.n1RJP699080658@svn.freebsd.org> <20090721145559.d2cf3f0b.stas@FreeBSD.org> <4A7AFFC4.5050607@tomjudge.com> <20090812234935.84e5ac74.stas@FreeBSD.org> <4A8337BD.3010700@delphij.net> <20090812225726.GI55129@michelle.cdnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20090812225726.GI55129@michelle.cdnetworks.com> WWW-Home-Page: http://mitya.pp.ru/ X-PGP-Key: http://mitya.pp.ru/mitya.asc User-Agent: Mutt/1.5.18 (2008-05-17) Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, David Christensen , Stanislav Sedov , Tom Judge , svn-src-head@freebsd.org, Xin LI Subject: Re: svn commit: r189117 - head/sys/dev/bce X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2009 08:33:55 -0000 On Wed, Aug 12, 2009 at 03:57:26PM -0700, Pyun YongHyeon wrote: > On Wed, Aug 12, 2009 at 02:44:29PM -0700, Xin LI wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > Hi, Stanislav, > > > > Stanislav Sedov wrote: > > > On Thu, 06 Aug 2009 11:07:32 -0500 > > > Tom Judge mentioned: > > > > > >> I can confirm that we are also seeing this problem on a number of Dell > > >> PE2950 systems running the bce driver from 7.2, the bug is more > > >> visible/producible on systems that are using Jumbo Frames (in our case 8Kb). > > >> > > >> The symptoms of this are an increase in the requests for jumbo clusters > > >> denied counter at 9k, and then random network stalls which sometimes > > >> recover on there own and others require a reboot. > > >> > > >> We have backed this change and so far it seems to have fixed the issue. > > >> > > > > > > David, > > > > > > are you OK with reverting this patch? I submitted the patch to re@ for > > > review, and I can commit it if you don't mind doing so. :-) > > > > I think there was some motivation supporting the SPLIT_HEADER disable in > > the past (IIRC it was for reliability or data corruption), but I think I > > have lost the mail archive (at least I couldn't find it at this moment > > :-/ I'm not very sure if that was fixed by my busdma_sync fix, though, > > can anyone confirm that? > > > > Since I don't have bce(4) hardwares I can't confirm it. I think the > busdma_sync fix would be prerequisite condition to fix data > corruption problem but I think it would not necessarily fix > previous data corruption issue. I wish you reach some consensus there because bce(4) is indeed broken and stas's patch seems to make it better.