From owner-freebsd-hackers Mon Mar 23 14:01:25 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id OAA21473 for freebsd-hackers-outgoing; Mon, 23 Mar 1998 14:01:25 -0800 (PST) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from relay1.kar.net (relay1.kar.net [195.5.17.66]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA21402 for ; Mon, 23 Mar 1998 14:01:13 -0800 (PST) (envelope-from kushn@mail.kar.net) Received: from olinet.isf.kiev.ua by relay1.kar.net with ESMTP id XAA10348; (8.8.last/vAk3/1.9) Mon, 23 Mar 1998 23:44:23 +0200 (EET) Received: from kushnir.kiev.ua by olinet.isf.kiev.ua with SMTP id XAA25530; (8.8.last/vAk3/1.9) Mon, 23 Mar 1998 23:44:34 +0200 (EET) Date: Mon, 23 Mar 1998 23:49:34 +0200 (EET) From: Vladimir Kushnir X-Sender: volodya@kushnir.kiev.ua Reply-To: Vladimir Kushnir To: freebsd-hackers@FreeBSD.ORG Subject: DEVFS awareness for VoxWare? Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hello, Sorry if this does not belong here or just plain stupid. Yes, I know fairly well this is not one of the urgent things (especially now), but since new sound driver does not yet support midi port, would not it make some sence to update a bit the old one? In particular, I mean adding DEVFS awareness to it. It doesn't seem to be too difficult (see patch below). It works (as it should to - after all, there's nothing new there). Unfortunately, I'm too ignorant as a programmer and can't suggest nothing better, but perhaps somebody would take a pain to improve it (to avoid silly code duplication with all unneeded if's) and add other supported cards (I've got only Yamaha SA2 card with MSS and SB simulations and OPL3 FM)? Regards, Vladimir /*--------------------sys/i386/isa/sound/soundcard.c.diff-----------------*/ *** ../tmp/soundcard.c Mon Mar 23 22:48:26 1998 --- soundcard.c Mon Mar 23 16:22:06 1998 *************** *** 26,33 **** --- 26,37 ---- * SUCH DAMAGE. * */ + #include "opt_devfs.h" #include + #ifdef DEVFS + #include + #endif /* DEVFS */ #if NSND > 0 /* from "snd.h" */ #include *************** *** 449,456 **** dev = makedev(CDEV_MAJOR, 0); cdevsw_add(&dev, &snd_cdevsw, NULL); } ! ! return TRUE; } --- 453,481 ---- dev = makedev(CDEV_MAJOR, 0); cdevsw_add(&dev, &snd_cdevsw, NULL); } ! #ifdef DEVFS ! /* if (dev->id_driver == &sbdriver || dev->id_driver == &gusdriver || ! dev->id_driver == &sbxvidriver || dev->id_driver == &mssdriver) */ ! if (dev->id_driver == &mssdriver) ! { ! devfs_add_devswf(&snd_cdevsw, (dev->id_unit << 4) | SND_DEV_DSP, DV_CHR, ! UID_ROOT, GID_WHEEL, 0666, "dsp%n", dev->id_unit); ! devfs_add_devswf(&snd_cdevsw, (dev->id_unit << 4) | SND_DEV_DSP16, DV_CHR, ! UID_ROOT, GID_WHEEL, 0666, "dspW%n", dev->id_unit); ! devfs_add_devswf(&snd_cdevsw, (dev->id_unit << 4) | SND_DEV_AUDIO, DV_CHR, ! UID_ROOT, GID_WHEEL, 0666, "audio%n", dev->id_unit); ! devfs_add_devswf(&snd_cdevsw, (dev->id_unit << 4) | SND_DEV_CTL, DV_CHR, ! UID_ROOT, GID_WHEEL, 0666, "mixer%n", dev->id_unit); ! devfs_add_devswf(&snd_cdevsw, (dev->id_unit << 4) | SND_DEV_STATUS, DV_CHR, ! UID_ROOT, GID_WHEEL, 0666, "sndstat%n", dev->id_unit); ! } ! else if (dev->id_driver == &opldriver) ! devfs_add_devswf(&snd_cdevsw, (dev->id_unit << 4) | SND_DEV_SEQ, DV_CHR, ! UID_ROOT, GID_WHEEL, 0666, "sequencer%n", dev->id_unit); ! else if (dev->id_driver == &mpudriver) ! devfs_add_devswf(&snd_cdevsw, (dev->id_unit << 4) | SND_DEV_MIDIN, DV_CHR, ! UID_ROOT, GID_WHEEL, 0666, "midi%n", dev->id_unit); ! #endif /* DEVFS */ return TRUE; } To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message