From owner-freebsd-current@FreeBSD.ORG Sat Apr 27 21:01:10 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 98A22A9D for ; Sat, 27 Apr 2013 21:01:10 +0000 (UTC) (envelope-from sendtomatt@gmail.com) Received: from mail-da0-x229.google.com (mail-da0-x229.google.com [IPv6:2607:f8b0:400e:c00::229]) by mx1.freebsd.org (Postfix) with ESMTP id 788EB1A81 for ; Sat, 27 Apr 2013 21:01:10 +0000 (UTC) Received: by mail-da0-f41.google.com with SMTP id p8so834399dan.0 for ; Sat, 27 Apr 2013 14:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=WDIDfhsabvlz0XGD92ceEYucY8MJWTdbMqNHlDwL6sw=; b=Q4QWpCo8U0TZ8DzcMVd6NLaBAuj2ca7nXyWdDqOG9eSPDdRkLN3nikaYYBwKGoyEC2 G0MjMNYc3UzcYvQpOoReQfvc/pDiN5ilSJzq1L6ib/W8CSFTJSSQHx9tVJLGi7xAIFAN tMuR/gS3FAEN9d54qc96sEZweLRipuep6iLxnqog42j6cOEHNAgVsvW/jD7C8y6oA1z4 kM2lsh+lbumETJZKFHRd+38gdZYFJICx4a+z40bLCT3da4QohQo0D+AO1YRB71tR7Ptt sCrmZBLxeDYYE6eDORNu1K5JwkgSE6wv44ZVCZWGDgaM3GxvqpaPdGaVaVESzvXA7WfW ksgA== X-Received: by 10.68.20.74 with SMTP id l10mr65756476pbe.150.1367096470226; Sat, 27 Apr 2013 14:01:10 -0700 (PDT) Received: from flatline.local (70-36-223-239.dsl.dynamic.sonic.net. [70.36.223.239]) by mx.google.com with ESMTPSA id nt2sm10611647pbc.17.2013.04.27.14.01.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 27 Apr 2013 14:01:09 -0700 (PDT) Message-ID: <517C3C87.1020005@gmail.com> Date: Sat, 27 Apr 2013 14:00:55 -0700 From: matt User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130405 Thunderbird/17.0.5 MIME-Version: 1.0 To: freebsd-current@FreeBSD.org Subject: r249939+ not detecting ata trim Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Apr 2013 21:01:10 -0000 I had been updating/porting Steve Hartland's patches for zfs trim on mps for 8.3 stable. Trim was working fine for me before r249939. When I saw that this functionality was being added to current, I built world/kernel without the patches. Indeed, many of the commits are quite similar to the updated patch I worked on (patch claims most of it is 'already applied'). HOWEVER, I am not seeing a delete method detected for either of my Samsung 830s, which I did under my updated patch. It looks like scsi ata identify is not working. Are there still outstanding commits to enable this, or is something now a tunable/sysctl I'm missing? Previously it was working: kstat.zfs.misc.zio_trim.bytes: 47546368 kstat.zfs.misc.zio_trim.success: 2618 kstat.zfs.misc.zio_trim.unsupported: 0 kstat.zfs.misc.zio_trim.failed: 0 Current: kstat.zfs.misc.zio_trim.bytes: 0 kstat.zfs.misc.zio_trim.success: 0 kstat.zfs.misc.zio_trim.unsupported: 264 kstat.zfs.misc.zio_trim.failed: 0 kern.cam.da.3.delete_method: NONE kern.cam.da.3.delete_max: 0 kern.cam.da.4.delete_method: NONE kern.cam.da.4.delete_max: 0 Thanks, Matt