From owner-freebsd-current@FreeBSD.ORG  Mon Oct 27 15:41:41 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D79271065671;
	Mon, 27 Oct 2008 15:41:41 +0000 (UTC) (envelope-from dds@aueb.gr)
Received: from mx-out.forthnet.gr (mx-out.forthnet.gr [193.92.150.104])
	by mx1.freebsd.org (Postfix) with ESMTP id 7123D8FC12;
	Mon, 27 Oct 2008 15:41:39 +0000 (UTC) (envelope-from dds@aueb.gr)
Received: from mx-av-04.forthnet.gr (mx-av.forthnet.gr [193.92.150.27])
	by mx-out-05.forthnet.gr (8.14.3/8.14.3) with ESMTP id m9RFOgTL017958; 
	Mon, 27 Oct 2008 17:24:43 +0200
Received: from MX-IN-01.forthnet.gr (mx-in-01.forthnet.gr [193.92.150.23])
	by mx-av-04.forthnet.gr (8.14.3/8.14.3) with ESMTP id m9RFOg7A014726;
	Mon, 27 Oct 2008 17:24:42 +0200
Received: from [192.168.136.16] (adsl14-101.kln.forthnet.gr [77.49.141.101])
	by MX-IN-01.forthnet.gr (8.14.3/8.14.3) with ESMTP id m9RFOYZ2003977;
	Mon, 27 Oct 2008 17:24:35 +0200
Authentication-Results: MX-IN-01.forthnet.gr smtp.mail=dds@aueb.gr; spf=neutral
Authentication-Results: MX-IN-01.forthnet.gr header.from=dds@aueb.gr;
	sender-id=neutral
Message-ID: <4905DD47.7040107@aueb.gr>
Date: Mon, 27 Oct 2008 17:24:55 +0200
From: Diomidis Spinellis <dds@aueb.gr>
User-Agent: Thunderbird 2.0.0.17 (Windows/20080914)
MIME-Version: 1.0
To: Andriy Gapon <avg@icyb.net.ua>, Harti Brandt <harti@FreeBSD.ORG>
References: <20080528110003.Q24259@beagle.kn.op.dlr.de>
	<483D5DF8.4020504@icyb.net.ua> <483F1559.2020600@aueb.gr>
In-Reply-To: <483F1559.2020600@aueb.gr>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Mon, 27 Oct 2008 16:14:36 +0000
Cc: current@FreeBSD.ORG
Subject: Re: cp(1) and mmap
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Oct 2008 15:41:41 -0000

Diomidis Spinellis wrote:
> Andriy Gapon wrote:
>> on 28/05/2008 12:02 Harti Brandt said the following:
>>> Hi all,
>>>
>>> it looks like there is no fallback in cp(1) when mmaping the source file
>>> fails. I'm mounting SMB shares via smbnetfs (which in turn uses fuse)
>>> and it seems not to support mmaping files. Shouldn't cp just fallback to
>>> a normal read()/write() loop in this case?
>>
>> I would think that it should.
>> This topic was brought up several times, but no resolution so far.
>> I think that I've even seen patches.
>>
> 
> I've not seen the patches, but the fix is trivial (see the attached 
> patch).  If there are no objections, I can commit it.

Fix committed in 184342.  Sorry for the long delay.

- dds