From owner-freebsd-net@FreeBSD.ORG Sat Sep 16 02:40:47 2006 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A0C1416A4EC for ; Sat, 16 Sep 2006 02:40:47 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.179]) by mx1.FreeBSD.org (Postfix) with ESMTP id 925DB43DB6 for ; Sat, 16 Sep 2006 02:01:26 +0000 (GMT) (envelope-from jfvogel@gmail.com) Received: by py-out-1112.google.com with SMTP id o67so3999440pye for ; Fri, 15 Sep 2006 19:01:25 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=iPUs6PKd2tP6a1J/ZmqN6pj7aIMm5ezKsmYsadHonbLT6GbsR1jJ9OCXooRgqId4DRFpcQV3DQFDwpb91RyIRjQsQgUbaZgjlaxjZ9THU+lJGa1t7Kudtdhxmc6wRbjp/2WKDMTLNp7bxeA9sS6tWflYYWh8q1zQkdEcib04UpA= Received: by 10.35.33.15 with SMTP id l15mr18505189pyj; Fri, 15 Sep 2006 19:01:25 -0700 (PDT) Received: by 10.35.119.1 with HTTP; Fri, 15 Sep 2006 19:01:25 -0700 (PDT) Message-ID: <2a41acea0609151901v5f24643dv4cf550a5108e1052@mail.gmail.com> Date: Fri, 15 Sep 2006 19:01:25 -0700 From: "Jack Vogel" To: "Gleb Smirnoff" , "Jack Vogel" , freebsd-net , "Prafulla Deuskar" In-Reply-To: <20060915142330.GS27667@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <2a41acea0609111402g68741d86ib185e9bb77908658@mail.gmail.com> <20060915142330.GS27667@FreeBSD.org> Cc: Subject: Re: Stale PCI ID X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Sep 2006 02:40:47 -0000 On 9/15/06, Gleb Smirnoff wrote: > On Mon, Sep 11, 2006 at 02:02:58PM -0700, Jack Vogel wrote: > J> In the last attempt to merge community CVS with Intel internal code I > J> came across an issue I'd like to bring up. > J> > J> There is an ancient e1000 card, pci id 1000, an 82542, that we > J> don't have in our source, yet community cvs still does. Support > J> for this was removed from Linux long ago because the card did > J> not even work. > J> > J> I just had our test group hunt up one of these and test, and sure > J> enough, the driver recognizes it, but it does NOT pass traffic. > J> > J> Clearly no one is using these, at least not with STABLE :) and > J> as Intel does not want to support this I would recommend removing > J> the ID from the driver. > J> > J> Comments? > > It should be removed then. When merging the Intel versions of driver to > FreeBSD, I've noticed that some PCI IDs disappeared from vendor driver. > Since I couldn't obtain any comments from the release tarball, I decided > to be on safe side and leave these PCI IDs in the driver untouched. > > Which exact one are you speaking about? The E1000_DEV_ID_82542, that is > equal to 0x1000 is supported by em-6.1.4 vendor's driver. I AM the vendor :) And I believe that the 0x1000 ID crept into my code from merging with your tree :) Our test group came back to me and said 'hey, this is old and we don't think these boards even work' , so I told them to test, they did, and sure enough, it wouldnt even pass traffic. There is actually 3 different rev boards, and rumor has it that the last revision would work, but I think its better to just drop the thing. Cheers, Jack