From owner-freebsd-hackers@FreeBSD.ORG  Mon Oct  5 17:01:31 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2B82E106566B
	for <freebsd-hackers@freebsd.org>; Mon,  5 Oct 2009 17:01:31 +0000 (UTC)
	(envelope-from tom@tomjudge.com)
Received: from tomjudge.vm.bytemark.co.uk (tomjudge.vm.bytemark.co.uk
	[80.68.91.100]) by mx1.freebsd.org (Postfix) with ESMTP id E3B948FC16
	for <freebsd-hackers@freebsd.org>; Mon,  5 Oct 2009 17:01:30 +0000 (UTC)
Received: from localhost (localhost.localdomain [127.0.0.1])
	by tomjudge.vm.bytemark.co.uk (Postfix) with ESMTP id C3784489C3
	for <freebsd-hackers@freebsd.org>; Mon,  5 Oct 2009 18:01:29 +0100 (BST)
X-Virus-Scanned: Debian amavisd-new at tomjudge.vm.bytemark.co.uk
Received: from tomjudge.vm.bytemark.co.uk ([127.0.0.1])
	by localhost (tomjudge.vm.bytemark.co.uk [127.0.0.1]) (amavisd-new,
	port 10024)
	with ESMTP id 660YSsuPD4s8 for <freebsd-hackers@freebsd.org>;
	Mon,  5 Oct 2009 18:01:26 +0100 (BST)
Received: from rita.nodomain (unknown [192.168.205.6])
	by tomjudge.vm.bytemark.co.uk (Postfix) with ESMTP id 524B2489BA
	for <freebsd-hackers@freebsd.org>; Mon,  5 Oct 2009 18:01:26 +0100 (BST)
Message-ID: <4ACA2645.30801@tomjudge.com>
Date: Mon, 05 Oct 2009 17:00:53 +0000
From: Tom Judge <tom@tomjudge.com>
User-Agent: Thunderbird 2.0.0.23 (X11/20090822)
MIME-Version: 1.0
To: freebsd-hackers@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Kernel Thread Lock Question
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Oct 2009 17:01:31 -0000

Do I need to hold the per thread lock here? (This is for 7.1)

PROC_LOCK(p);
//mtx_lock_spin(&sched_lock);
breakout = 0;
FOREACH_THREAD_IN_PROC(p, td) {
    thread_lock(td);
    if (!TD_ON_RUNQ(td) &&
            !TD_IS_RUNNING(td) &&
            !TD_IS_SLEEPING(td)) {
        breakout = 1;
        thread_unlock(td);
        break;
    }
    thread_unlock(td);
}
//mtx_unlock_spin(&sched_lock);
PROC_UNLOCK(p);


Thanks

Tom