From owner-freebsd-hackers@FreeBSD.ORG  Mon Jan  3 05:24:55 2011
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4137F106566B
	for <hackers@freebsd.org>; Mon,  3 Jan 2011 05:24:55 +0000 (UTC)
	(envelope-from lists@eitanadler.com)
Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com
	[209.85.210.182])
	by mx1.freebsd.org (Postfix) with ESMTP id D1F5B8FC14
	for <hackers@freebsd.org>; Mon,  3 Jan 2011 05:24:54 +0000 (UTC)
Received: by iyb26 with SMTP id 26so12323809iyb.13
	for <hackers@freebsd.org>; Sun, 02 Jan 2011 21:24:54 -0800 (PST)
Received: by 10.231.17.205 with SMTP id t13mr19974753iba.80.1294032293909;
	Sun, 02 Jan 2011 21:24:53 -0800 (PST)
MIME-Version: 1.0
Received: by 10.231.178.195 with HTTP; Sun, 2 Jan 2011 21:24:33 -0800 (PST)
In-Reply-To: <6DCC53BA-D20A-4593-B3B0-1389734AD308@turbofuzz.com>
References: <AANLkTimyXvm+6zyAobzxq-PCfBJus2ZMHvk5ztBOzufW@mail.gmail.com>
	<6DCC53BA-D20A-4593-B3B0-1389734AD308@turbofuzz.com>
From: Eitan Adler <lists@eitanadler.com>
Date: Mon, 3 Jan 2011 00:24:33 -0500
Message-ID: <AANLkTinXsksODj4vMcnPdhJ9wLROrriYEQidYfXLQJ-_@mail.gmail.com>
To: "Jordan K. Hubbard" <jkh@turbofuzz.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: hackers@freebsd.org
Subject: Re: [patch] should crunchgen use basename(3) instead of homebrew
	code?
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Jan 2011 05:24:55 -0000

Hi,

On Sun, Jan 2, 2011 at 11:50 PM, Jordan K. Hubbard <jkh@turbofuzz.com> wrot=
e:
> Wow. =C2=A0A couple of questions.

There was a reason my subject line was in the form of a question. When
poking around various parts of the "crypt" I noticed that the code
does something seemingly covered by an existing function so I decided
to poke the relevant people about it.  More generally - I don't like
seeing old code do something on its own that we have an existing
function for.  However your post convinced me that gain of consistency
is not worth the headaches it may cause.


--=20
Eitan Adler