From owner-cvs-sys  Sun Jul 30 11:44:18 1995
Return-Path: cvs-sys-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.11/8.6.6) id LAA19051
          for cvs-sys-outgoing; Sun, 30 Jul 1995 11:44:18 -0700
Received: from Root.COM ([198.145.90.1])
          by freefall.cdrom.com (8.6.11/8.6.6) with ESMTP id LAA19045
          ; Sun, 30 Jul 1995 11:44:15 -0700
Received: from corbin.Root.COM (corbin [198.145.90.18]) by Root.COM (8.6.11/8.6.5) with ESMTP id LAA01372; Sun, 30 Jul 1995 11:43:41 -0700
Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.11/8.6.5) with SMTP id LAA00185; Sun, 30 Jul 1995 11:44:56 -0700
Message-Id: <199507301844.LAA00185@corbin.Root.COM>
To: Bruce Evans <bde@zeta.org.au>
cc: CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com
Subject: Re: cvs commit: src/sys/kern tty.c 
In-reply-to: Your message of "Mon, 31 Jul 95 00:04:13 +1000."
             <199507301404.AAA09866@godzilla.zeta.org.au> 
From: David Greenman <davidg@Root.COM>
Reply-To: davidg@Root.COM
Date: Sun, 30 Jul 1995 11:44:55 -0700
Sender: cvs-sys-owner@freebsd.org
Precedence: bulk

>>bde         95/07/30 06:52:57
>
>>  Modified:    sys/kern  tty.c
>>  Log:
>>  Don't swap the queue headers to implement concatenation of the
>>  queues for TIOCSETA[W].  Swapping an even number of times broke
>>  the queue resource limits.  This would have broken CRTSCTS flow
>>  control if the clist slush list was used up.
>>  
>>  Don'concatenate the queues for TIOCSETA[W] if one of the queues
>>  has a resource limit of 0.  Concatenation would cause a panic if
>>  one of the queues is nonempty and the other is limited to length
>>  0.  This may have caused panics in PPPDISC.
>>  
>>  Wake up readers after all transitions of ICANON.  When ICANON is
>>  turned off it is quite likely that characters will become available
>>  to be read.
>>  
>>  Reduce indentation near these changes.
>
>This change should go in 2.1.

   There have been 14 commits to tty.c since it was branched for 2.1. I'm
slowly beginning to think that we should consider taking the bulk of the fixes
rather than doing this piece-meal. Many of the fixes are important and most of
them seem to be intertwined. Some of the changes are matched with changes to 
sio.c and other serial drivers...so these changes must be brought in, too.
   I'd like to hear other opinions about this.

-DG