Date: Sun, 30 Jul 1995 11:44:55 -0700 From: David Greenman <davidg@Root.COM> To: Bruce Evans <bde@zeta.org.au> Cc: CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com Subject: Re: cvs commit: src/sys/kern tty.c Message-ID: <199507301844.LAA00185@corbin.Root.COM> In-Reply-To: Your message of "Mon, 31 Jul 95 00:04:13 %2B1000." <199507301404.AAA09866@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
>>bde 95/07/30 06:52:57 > >> Modified: sys/kern tty.c >> Log: >> Don't swap the queue headers to implement concatenation of the >> queues for TIOCSETA[W]. Swapping an even number of times broke >> the queue resource limits. This would have broken CRTSCTS flow >> control if the clist slush list was used up. >> >> Don'concatenate the queues for TIOCSETA[W] if one of the queues >> has a resource limit of 0. Concatenation would cause a panic if >> one of the queues is nonempty and the other is limited to length >> 0. This may have caused panics in PPPDISC. >> >> Wake up readers after all transitions of ICANON. When ICANON is >> turned off it is quite likely that characters will become available >> to be read. >> >> Reduce indentation near these changes. > >This change should go in 2.1. There have been 14 commits to tty.c since it was branched for 2.1. I'm slowly beginning to think that we should consider taking the bulk of the fixes rather than doing this piece-meal. Many of the fixes are important and most of them seem to be intertwined. Some of the changes are matched with changes to sio.c and other serial drivers...so these changes must be brought in, too. I'd like to hear other opinions about this. -DG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199507301844.LAA00185>