From owner-cvs-all Thu Jan 2 9:43: 0 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C663E37B432 for ; Thu, 2 Jan 2003 09:42:41 -0800 (PST) Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215]) by mx1.FreeBSD.org (Postfix) with ESMTP id E316043E4A for ; Thu, 2 Jan 2003 09:42:40 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 20578 invoked from network); 2 Jan 2003 17:42:44 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail15.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 2 Jan 2003 17:42:44 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id h02HgcUT060250; Thu, 2 Jan 2003 12:42:39 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Thu, 02 Jan 2003 12:42:45 -0500 (EST) From: John Baldwin To: Nate Lawson Subject: Re: cvs commit: src/sys/vm vm_map.c vm_map.h Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org, "Alan L. Cox" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 31-Dec-2002 Nate Lawson wrote: > On Tue, 31 Dec 2002, Alan L. Cox wrote: >> Nate Lawson wrote: >> > Please use the non-underscore, exported mtx_* routines. The macros expand >> > to the same thing unless you're doing something strange w/ file and line >> > (but I don't see that in your patch). >> >> Yes, they expand to rather useless information: line X of _vm_map_lock. >> As I've written it, any messages will report the call site of >> _vm_map_lock, which is what we want to know. > > Thanks for correcting me. Any idea why the non-underscore funcs can't use > a more useful value like __LINE__? They do use __LINE__: #define mtx_lock_flags(m, opts) \ _mtx_lock_flags((m), (opts), LOCK_FILE, LOCK_LINE) and in sys/lock.h: #if LOCK_DEBUG > 0 #define LOCK_FILE __FILE__ #define LOCK_LINE __LINE__ #else #define LOCK_FILE NULL #define LOCK_LINE 0 #endif -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message