From owner-freebsd-current@freebsd.org Fri Nov 6 19:17:47 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3D2E1447209 for ; Fri, 6 Nov 2020 19:17:47 +0000 (UTC) (envelope-from mike@sentex.net) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4CSVXC0SZtz4dw0 for ; Fri, 6 Nov 2020 19:17:47 +0000 (UTC) (envelope-from mike@sentex.net) Received: by mailman.nyi.freebsd.org (Postfix) id 0DF8C446F30; Fri, 6 Nov 2020 19:17:47 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0C862446F2F for ; Fri, 6 Nov 2020 19:17:47 +0000 (UTC) (envelope-from mike@sentex.net) Received: from pyroxene2a.sentex.ca (pyroxene19.sentex.ca [IPv6:2607:f3e0:0:3::19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "pyroxene.sentex.ca", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CSVXB2fcjz4dms; Fri, 6 Nov 2020 19:17:46 +0000 (UTC) (envelope-from mike@sentex.net) Received: from [IPv6:2607:f3e0:0:4:adfd:30ed:295d:5262] ([IPv6:2607:f3e0:0:4:adfd:30ed:295d:5262]) by pyroxene2a.sentex.ca (8.15.2/8.15.2) with ESMTPS id 0A6JHiDL007894 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Fri, 6 Nov 2020 14:17:45 -0500 (EST) (envelope-from mike@sentex.net) Subject: Link flap when adding / removing a vlan (was Re: r360902 breaks VLAN interface on if_em (82579LM)) To: lev@FreeBSD.org, current@freebsd.org References: <88004d48-4434-875a-5a36-0627b00c2f38@gmail.com> <1906251966.36777.1590562439792.JavaMail.open-xchange@opme11oxm03aub.bagnolet.francetelecom.fr> <997c1389-5e18-b07e-d342-c787c841a4c4@gmail.com> <711876429.20200601003941@serebryakov.spb.ru> From: mike tancsa Message-ID: Date: Fri, 6 Nov 2020 14:17:46 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <711876429.20200601003941@serebryakov.spb.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 4CSVXB2fcjz4dms X-Spamd-Bar: / X-Spamd-Result: default: False [-0.79 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[mike]; FROM_HAS_DN(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f3e0:0:3::19:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; HFILTER_HELO_IP_A(1.00)[pyroxene2a.sentex.ca]; HFILTER_HELO_NORES_A_OR_MX(0.30)[pyroxene2a.sentex.ca]; SPAMHAUS_ZRD(0.00)[2607:f3e0:0:3::19:from:127.0.2.255]; DMARC_NA(0.00)[sentex.net]; R_SPF_ALLOW(-0.20)[+ip6:2607:f3e0::/32]; NEURAL_HAM_SHORT(-0.79)[-0.788]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:11647, ipnet:2607:f3e0::/32, country:CA]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 19:17:47 -0000 On 5/31/2020 5:39 PM, Lev Serebryakov wrote: > Hello Ian, > > Thursday, May 28, 2020, 2:45:48 AM, you wrote: > >> I noticed that my VLAN interfaces stopped working after a recent build.  >> tcpdump showed traffic leaving leaving and entering the interface but no >> host on the network actually received any packets from this host.  A >> binary search led me to r360902 and indeed the following change fixed >> the issue for me: > Problem is, this change will return terrible situation when adding new VLAN > will flap connection status. > > It all worked before iflib: hardware VLAN filtering worked, and > adding/removing new VLAN didn't cause link to flap. > > Now, with iflib, looks like we can not have all good things at once :( Hi All, Just came across this thread as I am running into this behaviour on RELENG_12.  Adding a new vlan causes all vlans on the parent interface to flap. Not the greatest thing as it bounces a LOT of traffic potentially, flaps routing etc.  Is there a way around this ? This is on r367411 releng12 igb0@pci0:2:0:0:        class=0x020000 card=0x153315d9 chip=0x15338086 rev=0x03 hdr=0x00     vendor     = 'Intel Corporation'     device     = 'I210 Gigabit Network Connection'     class      = network     subclass   = ethernet eg. just something simple like ifconfig vlan16 create 10.1.2.3/29 vlandev igb1 vlan 16  # dmesg | tail -8 igb1: link state changed to DOWN vlan16: link state changed to DOWN vlan2049: link state changed to DOWN vlan15: link state changed to DOWN igb1: link state changed to UP vlan16: link state changed to UP vlan2049: link state changed to UP vlan15: link state changed to UP     ---Mike