From owner-freebsd-scsi@FreeBSD.ORG Thu Oct 23 06:37:52 2003 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D89816A4B3; Thu, 23 Oct 2003 06:37:52 -0700 (PDT) Received: from melusine.cuivre.fr.eu.org (melusine.cuivre.fr.eu.org [62.212.105.185]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8473B43F85; Thu, 23 Oct 2003 06:37:51 -0700 (PDT) (envelope-from thomas@FreeBSD.ORG) Received: by melusine.cuivre.fr.eu.org (Postfix, from userid 1000) id 1854C2A42B; Thu, 23 Oct 2003 15:37:49 +0200 (CEST) Date: Thu, 23 Oct 2003 15:37:49 +0200 From: Thomas Quinot To: Poul-Henning Kamp Message-ID: <20031023133748.GA33994@melusine.cuivre.fr.eu.org> References: <20031018110146.1073816A4DF@hub.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="azLHFNyN32YCQGCU" Content-Disposition: inline In-Reply-To: <20031018110146.1073816A4DF@hub.freebsd.org> User-Agent: Mutt/1.4i X-message-flag: WARNING! Using Outlook can damage your computer. cc: freebsd-scsi@freebsd.org Subject: Re: [src] cvs commit: src/sys/cam cam_periph.c X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Oct 2003 13:37:52 -0000 --azLHFNyN32YCQGCU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Poul-Henning Kamp, 2003-10-18 : > There is no need to muck about with the B_PHYS flag here. We never even > get close to DEV_STRATEGY() which is the only place it is relevant. > =20 > Revision Changes Path > 1.54 +0 -8 src/sys/cam/cam_periph.c I'm afraid this change is wrong. > - /* set the flags */ > - mapinfo->bp[i]->b_flags =3D B_PHYS; > - 12 lines below that point, we call vmapbuf(mapinfo->bp[i]), which will panic if B_PHYS is not set. Please consider a backout. Thomas. --=20 Thomas.Quinot@Cuivre.FR.EU.ORG --azLHFNyN32YCQGCU Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (FreeBSD) iD8DBQE/l9mrAE1UuDk9JGkRAu+cAJ9w7+WWO8pg+czM/Pxb3IfsHVBALgCfaTUn oUeggj0nvGttkXK8+LeesXo= =U4z7 -----END PGP SIGNATURE----- --azLHFNyN32YCQGCU--