From owner-cvs-all@FreeBSD.ORG Tue Jun 14 06:22:47 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 027C016A41C; Tue, 14 Jun 2005 06:22:47 +0000 (GMT) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [210.51.165.229]) by mx1.FreeBSD.org (Postfix) with ESMTP id 85B8643D4C; Tue, 14 Jun 2005 06:22:46 +0000 (GMT) (envelope-from delphij@delphij.net) Received: from beastie.frontfree.net (unknown [219.239.99.7]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTP id 0731FEB0FFA; Tue, 14 Jun 2005 14:22:43 +0800 (CST) Received: from localhost (localhost.frontfree.net [127.0.0.1]) by beastie.frontfree.net (Postfix) with ESMTP id 275EF133A10; Tue, 14 Jun 2005 14:22:38 +0800 (CST) Received: from beastie.frontfree.net ([127.0.0.1]) by localhost (beastie.frontfree.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 25540-08; Tue, 14 Jun 2005 14:22:32 +0800 (CST) Received: from [10.217.12.87] (unknown [61.135.152.194]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by beastie.frontfree.net (Postfix) with ESMTP id CF5C713167B; Tue, 14 Jun 2005 14:22:31 +0800 (CST) From: Xin LI To: Peter Wemm In-Reply-To: <200506140243.j5E2hjnh044694@repoman.freebsd.org> References: <200506140243.j5E2hjnh044694@repoman.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-VQhcCQignH6H1lQyOiet" Organization: The FreeBSD Simplified Chinese Project Date: Tue, 14 Jun 2005 14:22:27 +0800 Message-Id: <1118730147.733.6.camel@spirit> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at frontfree.net Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/syscons scgfbrndr.c scvgarndr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2005 06:22:47 -0000 --=-VQhcCQignH6H1lQyOiet Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > peter 2005-06-14 02:43:45 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/syscons scgfbrndr.c scvgarndr.c=20 > Log: > Fix syscons on amd64. The SC_PIXEL_MODE commit from May 29th added a n= ew > function pointer to the vga render dispatch table and initialized it wi= th > vga_nop. The problem is that vga_nop() is a varargs function, and the > table declares a non-varargs function pointer. On amd64 (and I think p= pc), > mixing varargs and non-varargs function pointers is fatal. > =20 > Change vga_nop() and gfb_nop() from varargs to non-varargs do-nothing > functions. This stops the stack corruption that only happened on amd64= . Thanks! --=20 Xin LI http://www.delphij.net/ --=-VQhcCQignH6H1lQyOiet Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQBCrnej/cVsHxFZiIoRAtcqAJ9sVvTLMQ4YbqDmC27TnZ6puxax7gCdHTJe uhws6ajrGLQW7swzLiQ0mdA= =RDeL -----END PGP SIGNATURE----- --=-VQhcCQignH6H1lQyOiet--