From owner-freebsd-current@FreeBSD.ORG Wed Oct 10 17:36:07 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A023B16A418 for ; Wed, 10 Oct 2007 17:36:07 +0000 (UTC) (envelope-from is@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.freebsd.org (Postfix) with ESMTP id 4C3A513C465 for ; Wed, 10 Oct 2007 17:36:07 +0000 (UTC) (envelope-from is@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id 0EF9AE607; Wed, 10 Oct 2007 21:36:06 +0400 (MSD) Received: from localhost (is1.park.rambler.ru [81.19.64.121]) by relay0.rambler.ru (Postfix) with ESMTP id DBF53CCB3; Wed, 10 Oct 2007 21:36:05 +0400 (MSD) Date: Wed, 10 Oct 2007 21:36:01 +0400 From: Igor Sysoev To: David G Lawrence Message-ID: <20071010173601.GB35652@rambler-co.ru> References: <20071009125001.GC5758@rambler-co.ru> <20071010055748.GA18931@rambler-co.ru> <20071010060605.GB18931@rambler-co.ru> <470C6DD4.1060509@mawer.org> <20071010062541.GA23840@rambler-co.ru> <20071010093436.GB2180@deviant.kiev.zoral.com.ua> <20071010095018.GA28123@rambler-co.ru> <20071010102756.GE56714@tnn.dglawrence.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20071010102756.GE56714@tnn.dglawrence.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-Virus-Scanned: No virus found Cc: Kostik Belousov , freebsd-current@freebsd.org, Antony Mawer Subject: Re: sendfile and page usage statistics X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2007 17:36:07 -0000 On Wed, Oct 10, 2007 at 03:27:56AM -0700, David G Lawrence wrote: > > > But I think that the actual patch is wrong. The PG_REFERENCED bit shall > > > be set when hardware access bit is set on pte. You patch would set it in > > > advance. > > > > The problem is that ethernet card that does TX chsum, DMA and TSO never > > sets PG_A, so sendfile() should set it in advance. > > > > I'm going to test the patch on machine where all files takes more memory > > than physical memory and there are some popular files. > > > > I espect to see > > 1) increased active memory. > > 2) decreased number i/o. > > I would say that it is far from clear that this change would result in > better performance. It is generally the case in FreeBSD that we bias in > favor of executable pages (usually the image itself as its pages are > executed, but also the image data pages). Pages involved in regular file > I/O take a back seat. This is because a regular file is accessed typically > in one burst, whereas an executable page is accessed in small chunks over > a much larger period of time (and thus is affected more by a cache miss). > Thus, PG_REFERENCED gets set for pages that are mmaped, but not for > pages involved in read, write, sendfile, etc. Different workloads of > course will have different behavior. > One side effect of this will likely be much more system paging activity > as sendfile causes process pages to be pushed out of memory in favor of > cached file data. This is generally a bad thing and would result in reduced > interactive performance. The read() from file certainly updates vnode pages' PG_A/PG_REFERENCED, because coping to userland is made by CPU. I think write() does the same. I consider sendfile() as send() of mmap()ed file with the difference that user process does not see this mmap(). -- Igor Sysoev http://sysoev.ru/en/