From owner-freebsd-toolchain@FreeBSD.ORG Tue Sep 30 15:10:27 2014 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3B7A5D2 for ; Tue, 30 Sep 2014 15:10:27 +0000 (UTC) Received: from mail-qg0-f43.google.com (mail-qg0-f43.google.com [209.85.192.43]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F1EA59C9 for ; Tue, 30 Sep 2014 15:10:26 +0000 (UTC) Received: by mail-qg0-f43.google.com with SMTP id j107so4918264qga.2 for ; Tue, 30 Sep 2014 08:10:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=I1iKo4JLtO0nW+taA6rrVtyszjZRmwchFAnCqha9EO4=; b=mf07TsxETcZSUjz1x4i0BeJfkNTB/rwHa5MZ8lVePqFHQJWGndSs55l/caSG6wXNpr fSdTdnSC4Q8WG4/23QknH3At9f1jAHajnWPLWs0gjwd/h1snVMph04q2SDRi09yJ29U4 Q0zwibx+nOLxzTJqDXWSQ+5fX6WBydvqVyIhzBMbJCBEa86SIjArqni7TSI3rwINGiAN SAPwuUdQs0NNeluSBUmXHeuAKzBQTXigA42G1tCnwgt0rSSvyd9rJMRlKqgVqM5t/nAN DI8bymaJJR44OEAdR67jfYYSOkmjnZlCjwoeURQP1KHzvCuHuplNfOwW6qFyoijdcl63 Wbuw== X-Gm-Message-State: ALoCoQnJtYcvhYMb6U0Dzm+APVgLGPxVrpjcIXuwfrO9Gw5TqzOrh3tRGZwuem+vefozanGjWh3/ MIME-Version: 1.0 X-Received: by 10.224.127.131 with SMTP id g3mr20151899qas.81.1412089816240; Tue, 30 Sep 2014 08:10:16 -0700 (PDT) Received: by 10.140.16.183 with HTTP; Tue, 30 Sep 2014 08:10:16 -0700 (PDT) In-Reply-To: <20140930113544.GA7285@soulhacker> References: <20140930113544.GA7285@soulhacker> Date: Tue, 30 Sep 2014 09:10:16 -0600 Message-ID: Subject: Re: elftoolchain update? From: Will Andrews To: Kai Wang Content-Type: text/plain; charset=UTF-8 Cc: jkoshy@freebsd.org, freebsd-toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Sep 2014 15:10:27 -0000 Thanks Kai. Could you please review the changes I made on my branch? I'm still working on this issue. --Will. On Tue, Sep 30, 2014 at 5:35 AM, Kai Wang wrote: > Hello Will, > > My apologies for the delayed reply. I've totally missed these few > emails. > > I can investigate the C++ object files issue and make fixes for > them ASAP. > > Regarding header, it was used for elftoolchain to > build on various OS independently. When merging elftoolchain back to > FreeBSD, I found it's very hard to use the header > because of the conflicts. So I decided to continue using the existing > system ELF headers. You approach of merging the missing defines from > to the elfXX.h headers looks good to me. > > Thanks, > Kai > > On Fri, Sep 26, 2014 at 11:32:20AM -0600, Will Andrews wrote: >> Hi, >> >> I've created a git-svn clone of the current elftoolchain, and applied >> some fixes in a branch: >> https://github.com/wca/elftoolchain/tree/freebsd >> >> Any objections if I update the copy in head using this branch? I've >> heard nothing from either Kai or Joseph. >> >> I'm not done testing yet -- it looks like there are some more bugfixes >> needed to get ctfconvert to at least run against C++ object files >> without bailing. Just wanted to know if there are any specific >> concerns that people might have. >> >> A related review involves an update for the ELF headers: >> https://reviews.freebsd.org/D844 >> >> I haven't finished testing this either (need to do an universe build >> to check for conflicts), but my goal here is to achieve header parity >> with from elftoolchain, which is largely duplicate. >> The elftoolchain header exports many more symbols that are used by its >> userland programs. This would include arch-specific interpretations >> of some ELF structures. I believe it's appropriate to export these on >> a global basis, given that userland programs can legitimately be run >> on object files built for architectures other than the system they're >> running on. >> >> Thanks! >> --Will. >> >> On Wed, Sep 17, 2014 at 5:01 PM, Will Andrews wrote: >> > Hi, >> > >> > I see there have been a lot of updates & fixes to elftoolchain since >> > the last import into FreeBSD/head nearly 8 months ago. Are there any >> > plans to update the import? >> > >> > I'm asking because it appears that ctfconvert currently crashes >> > (specifically, due to a bug in dwarf_attrval_unsigned()), if you try >> > to use it on C++ object files. >> > >> > This is easily demonstrated by applying this patch to FreeBSD/head and >> > building sbin/devd with WITH_CTF=1: >> > http://people.freebsd.org/~will/add-ctfconvert-to-cpp-object-files.diff >> > >> > Justin Gibbs (cc'd) posted about this issue in February, and it's >> > still a problem: >> > http://lists.freebsd.org/pipermail/freebsd-toolchain/2014-February/001121.html >> > >> > Thanks, >> > --Will.