From owner-svn-src-head@freebsd.org Wed Dec 20 20:54:51 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DD514EA46BF; Wed, 20 Dec 2017 20:54:51 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A01AA2DF1; Wed, 20 Dec 2017 20:54:51 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id vBKKsnPN027868; Wed, 20 Dec 2017 12:54:49 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id vBKKsnPV027867; Wed, 20 Dec 2017 12:54:49 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201712202054.vBKKsnPV027867@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r327005 - in head: sbin/ipfw sys/sys usr.sbin/watch In-Reply-To: <34c37415-002a-f5fa-7a06-e98bcfc9c133@FreeBSD.org> To: Pedro Giffuni Date: Wed, 20 Dec 2017 12:54:49 -0800 (PST) CC: rgrimes@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Reply-To: rgrimes@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 20:54:52 -0000 > On 12/19/17 21:55, Rodney W. Grimes wrote: > >> > >>> On Dec 19, 2017, at 19:15, Rodney W. Grimes wrote: > >>> > >>>> Author: pfg > >>>> Date: Tue Dec 19 22:40:16 2017 > >>>> New Revision: 327005 > >>>> URL: https://svnweb.freebsd.org/changeset/base/327005 > >>>> > >>>> Log: > >>>> SPDX: These are fundamentally BSD-2-Clause. > >>>> > >>>> They just omit the introductory line and numbering. > >>> I again must assert that it would be better to not apply an SPDX than to > >>> apply one that is not an exact match for the license. > >>> > >>> > >> Not being a lawyer, I would normally agree, however: > > This isnt about any legal issue. > > > >> 1) SPDX IDs are only advisory: we always keep the exact license text, which is what has legal value. > > And we should do our best to provide the most accurate advisory we can, > > and we know that this is not a direct copy of the BSD 2 clause, so making > > advice that it is, IMHO, would be poor advice. > > > >> 2) The license is detected by license scanners as BSD and it has two clauses so the description fits. > > And a human reading it sees it reads like a 2 clause but does not match a 2 clause exactly so > > how do I trust any of this SPDX stuff as being done with some ration of sanity. > > > >> FWIW, according to SPDX lawyers, the numbering is not relevant and it would appear to me that the phrase: > >> "Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:? doesn?t add any information to the two clauses, which read: > > Again, not a legal issue, an issue of this is not an exact BSD-2-Clause so I > > do not believe that we should tag it as such. Basically if we are doing this > > "close enough" thing it means the SPDX tags are actually pretty useless for > > anyone trying to do a legal evaluation cause they are just going have to > > completly redo what was done in adding the SPDX tags, and if that is the > > case we should seriously consider just what value do these have in the > > tree? > > > > > Indeed .. after having the change reviewed by someone objective, I have > reverted the change in r327040. > > Thanks for speaking up! No problem, and I have now also read the guidlines and to a larger extent most of the SPDX spec so I am now also more informed. Thanks for going the extra mile to get clarification! > Pedro. -- Rod Grimes rgrimes@freebsd.org