From owner-freebsd-current Sat Dec 26 22:11:59 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA15492 for freebsd-current-outgoing; Sat, 26 Dec 1998 22:11:59 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from st-lcremean.tidalwave.net (host-e186.tidalwave.net [208.213.203.186] (may be forged)) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA15485; Sat, 26 Dec 1998 22:11:48 -0800 (PST) (envelope-from lee@st-lcremean.tidalwave.net) Received: (from lee@localhost) by st-lcremean.tidalwave.net (8.9.1/8.8.8) id BAA95630; Sun, 27 Dec 1998 01:11:27 -0500 (EST) (envelope-from lee) Message-ID: <19981227011127.A95605@tidalwave.net> Date: Sun, 27 Dec 1998 01:11:27 -0500 From: Lee Cremeans To: current@FreeBSD.ORG Cc: foxfair@FreeBSD.ORG Subject: pcisupport.c 1.85 breaks ide_pci and USB on VIA boards Reply-To: lcremean@tidalwave.net Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.93.2i X-OS: FreeBSD 3.0-CURRENT X-Evil: microsoft.com Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG The changes foxfair made in pcisupport.c for the VIA chipset included entries for the VIA Apollo IDE and USB controllers. This change breaks support for both of them on machines with VP1/VP2/[M]VP3 chipsets, since both functions have their own drivers. For future reference, I should note that only PCI north and south bridges, VGA cards, and things we don't have explicit driver support for elsewhere should be in pcisupport.c, since having them in there basically serves only to show people what chips are on their motherboards (and to work around quirks in a few chipsets). PCI IDE is in /sys/pci/ide_pci.c, USB is in /sys/dev/pci/ohci_pci.c and uhci_pci.c, and if there's an entry for a chip in pcisupport.c that another driver should be covering, that driver will never see the PCI probe--the buck stops at pcisupport.c. By the way, the other MVP3 ID patches seem to work fine here, on my shiny new Soyo SY-5EHM. :) Here's the patch to back out the changes pertinent to this. *** pcisupport.c.orig Sun Dec 27 01:05:24 1998 --- pcisupport.c Sun Dec 27 01:05:52 1998 *************** *** 342,352 **** /* XXX need info on the MVP3 -- any takers? */ case 0x30401106: return("VIA 82C586B ACPI interface"); - /* XXX New info added-in */ - case 0x05711106: - return("VIA 82C586B IDE controller"); - case 0x30381106: - return("VIA 82C586B USB controller"); /* XXX Here is MVP3, I got the datasheet but NO M/B to test it */ /* totally. Please let me know if anything wrong. -F */ case 0x05981106: --- 342,347 ---- -- +--------------------------------------------------------------------+ | Lee Cremeans -- Manassas, VA, USA (WakkyMouse on DALnet and WTnet)| | lcremean@tidalwave.net| http://st-lcremean.tidalwave.net | To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message