From owner-freebsd-stable  Wed Sep 20  8:55:14 2000
Delivered-To: freebsd-stable@freebsd.org
Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11])
	by hub.freebsd.org (Postfix) with SMTP id 1AEE237B423
	for <stable@freebsd.org>; Wed, 20 Sep 2000 08:55:06 -0700 (PDT)
Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP
          id <aa27854@salmon>; 20 Sep 2000 16:55:05 +0100 (BST)
Date: Wed, 20 Sep 2000 16:55:05 +0100
From: David Malone <dwmalone@maths.tcd.ie>
To: Maxime Henrion <mux@qualys.com>
Cc: stable@freebsd.org, bright@wintelcom.net
Subject: Re: patch for inetd
Message-ID: <20000920165505.A56705@walton.maths.tcd.ie>
References: <39C8D00D.FBE1407F@qualys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <39C8D00D.FBE1407F@qualys.com>; from mux@qualys.com on Wed, Sep 20, 2000 at 04:56:13PM +0200
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> *** /usr/src/usr.sbin/inetd/builtins.c	Wed Sep 20 16:49:26 2000
> --- builtins.c	Wed Jul 19 22:27:19 2000
> ***************
> *** 480,487 ****
>   		ssize = read(s, &buf[size], (size_t)onreadlen);
>   		if (ssize == -1)
>   			iderror(0, 0, s, errno);
> - 		else if (ssize == 0)
> - 			return;
>   		bufsiz -= ssize;
>   		size += ssize;
>    	}
> --- 480,485 ----

You don't wan't to return from the ident builtin, I'd actually
suggest "break;" to see if you've recieved enough of a request to
be able to answer. You may still be able to send data to the other
end, as they may just have shutdown half of the connection.

Alfred's patch with the iderror for the EOF case is reasonable,
but I'd be as lienient as possible and attempt to answer the request.

I'll test the patch with a break; when I get home and see if it
works OK. If alfred thinks it's OK I'll commit it.

	David.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message