From owner-svn-ports-all@freebsd.org  Sun Jun 18 01:25:31 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 98282C794C0;
 Sun, 18 Jun 2017 01:25:31 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 750667E58E;
 Sun, 18 Jun 2017 01:25:31 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (localhost [127.0.0.1])
 by ainaz.pair.com (Postfix) with ESMTP id 75B4C3F650;
 Sat, 17 Jun 2017 21:25:29 -0400 (EDT)
Received: from anthias.dhcp.nue.suse.com (charybdis-ext.suse.de
 [195.135.221.2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ainaz.pair.com (Postfix) with ESMTPSA id C57C43F4D9;
 Sat, 17 Jun 2017 21:25:28 -0400 (EDT)
Date: Sun, 18 Jun 2017 03:25:27 +0200 (CEST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Jan Beich <jbeich@FreeBSD.org>
cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, 
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r443793 - head/lang/gcc7-devel
In-Reply-To: <d1a2-9k83-wny@FreeBSD.org>
Message-ID: <alpine.LSU.2.21.1706180321130.2749@anthias.pfeifer.com>
References: <201706172327.v5HNRbGE015821@repo.freebsd.org>
 <d1a2-9k83-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Jun 2017 01:25:31 -0000

On Sun, 18 Jun 2017, Jan Beich wrote:
>>   When we set STAGE1_CXXFLAGS / CXXFLAGS in MAKE_FLAGS for arm platforms,
>>   do so incrementally (with += instead of =).
> Did you mean to use MAKE_ENV instead of +=?

I'm not sure. ;-)  In your example, += did not actually work in
the MAKE_ENV tests, did it?

Did you mean that the commit message should have referred to
MAKE_ARGS instead of MAKE_FLAGS?  If so, I agree, that was a
"typo" of mine.

If there is anything beyond that, I am not seeing it right now,
but I simply may be too tired (so a patch might be best).

Thanks,
Gerald