Date: Sun, 21 Aug 2011 11:44:54 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Chris Rees <crees@freebsd.org> Cc: Rene Ladan <rene@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/www/chromium Makefile Message-ID: <20110821114454.GA77777@FreeBSD.org> In-Reply-To: <CADLo838r7ksFKTjB24NBVTtnyDaf54jdz9aQ9Ggb22CtsvA9ng@mail.gmail.com> References: <201108211100.p7LB0cB7060742@repoman.freebsd.org> <CADLo838r7ksFKTjB24NBVTtnyDaf54jdz9aQ9Ggb22CtsvA9ng@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Aug 21, 2011 at 12:04:37PM +0100, Chris Rees wrote:
> On 21 August 2011 12:00, Rene Ladan <rene@freebsd.org> wrote:
> > rene š š š š2011-08-21 11:00:38 UTC
> >
> > šModified files:
> > š šwww/chromium š š š š Makefile
> > šLog:
> > šDo not hardcode the patch directory as "files", use ${FILESDIR} instead.
>
> Shouldn't it be PATCHDIR?
Ideally, only one should stay, I don't really care which one (although
FILESDIR is maybe a bit better as it's more generic -- there might be not
only patches, but drop-in files, etc).
I wanted to look at merging FILESDIR/PATCHDIR logic in bpm several years
ago, but didn't go much further.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110821114454.GA77777>