From owner-cvs-ports@FreeBSD.ORG  Tue Jun 12 17:05:17 2012
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id AFA6710657B4;
	Tue, 12 Jun 2012 17:05:17 +0000 (UTC)
	(envelope-from utisoft@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id A44748FC1D;
	Tue, 12 Jun 2012 17:05:16 +0000 (UTC)
Received: by bkvi18 with SMTP id i18so5880989bkv.13
	for <multiple recipients>; Tue, 12 Jun 2012 10:05:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:from:date
	:x-google-sender-auth:message-id:subject:to:cc:content-type
	:content-transfer-encoding;
	bh=N9+gVCWZZw2nAatoZ28KSa6SJMwK5D2Rw5Dr8D9yjeY=;
	b=JGSl1eKnokR3PjNHl/EFp3dS+lPkaZBuhizoq6XZ1ryoQkaGdb4kg3xWr3S90SPVaK
	C1k80i7Uivmir3j3UW5WbmOEymRoyWmWXcCWGnQjh9yH6Is0gpgBuAcBmYpsBSsFy6O9
	AaInoWk8Cgc4NkYPGCZdt9+TDyCBG156ohVyr0c0IDUkUhvvRGqssUn3nEZr/7F/yiV2
	pzWAZkxBuHtXJGcxzLcJ3HAq2aIx7JAh5FFD9/vJSEhq9FB/2Ci457uL1VMA2gBfnvlI
	S96Ij5yi8Pmg3u7Bia/NLhVzLoRc2V5N9LgwmI9DdgfEcul2DYaLdC2SXPiAby5df4Bi
	w87A==
Received: by 10.204.156.69 with SMTP id v5mr11905372bkw.133.1339520715447;
	Tue, 12 Jun 2012 10:05:15 -0700 (PDT)
MIME-Version: 1.0
Sender: utisoft@gmail.com
Received: by 10.204.171.138 with HTTP; Tue, 12 Jun 2012 10:04:45 -0700 (PDT)
In-Reply-To: <201206121651.q5CGpop5037088@repoman.freebsd.org>
References: <201206121651.q5CGpop5037088@repoman.freebsd.org>
From: Chris Rees <crees@FreeBSD.org>
Date: Tue, 12 Jun 2012 18:04:45 +0100
X-Google-Sender-Auth: qKd1anl75cTHVVHLXi-5RYkLWvM
Message-ID: <CADLo839KPaf-9wqVEb8DcnSJHkq3318jV_dna44bprfKO92gvQ@mail.gmail.com>
To: Mikhail Teterin <mi@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject: Re: cvs commit: ports/databases/adstudio Makefile distinfo
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jun 2012 17:05:17 -0000

On 12 June 2012 17:51, Mikhail Teterin <mi@freebsd.org> wrote:
> mi =A0 =A0 =A0 =A0 =A02012-06-12 16:51:50 UTC
>
> =A0FreeBSD ports repository
>
> =A0Modified files:
> =A0 =A0databases/adstudio =A0 Makefile distinfo
> =A0Log:
> =A0Upgrade from 10.0.7 to 10.0.11. Unbreak.
>
> =A0Revision =A0Changes =A0 =A0Path
> =A01.51 =A0 =A0 =A0+9 -6 =A0 =A0 =A0ports/databases/adstudio/Makefile
> =A01.43 =A0 =A0 =A0+4 -2 =A0 =A0 =A0ports/databases/adstudio/distinfo
>


-	${TAR} -C ${DATADIR} -xpf ${DISTDIR}/${_DISTFILES}	\
+	# Extracting the base version:
+	${TAR} -C ${DATADIR} -xpf ${DISTDIR}/${EXTRACT_ONLY}	\
 		${INSTFILES:S|^|./datastudio/|}

This looks very fragile to me, since by definition EXTRACT_ONLY is a list.

It'd be better off wrapped in a .for, or use ${EXTRACT_ONLY:S/^/${DISTDIR}/=
}

Chris