Date: Tue, 12 Jun 2012 18:04:45 +0100 From: Chris Rees <crees@FreeBSD.org> To: Mikhail Teterin <mi@freebsd.org> Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/databases/adstudio Makefile distinfo Message-ID: <CADLo839KPaf-9wqVEb8DcnSJHkq3318jV_dna44bprfKO92gvQ@mail.gmail.com> In-Reply-To: <201206121651.q5CGpop5037088@repoman.freebsd.org> References: <201206121651.q5CGpop5037088@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12 June 2012 17:51, Mikhail Teterin <mi@freebsd.org> wrote:
> mi =A0 =A0 =A0 =A0 =A02012-06-12 16:51:50 UTC
>
> =A0FreeBSD ports repository
>
> =A0Modified files:
> =A0 =A0databases/adstudio =A0 Makefile distinfo
> =A0Log:
> =A0Upgrade from 10.0.7 to 10.0.11. Unbreak.
>
> =A0Revision =A0Changes =A0 =A0Path
> =A01.51 =A0 =A0 =A0+9 -6 =A0 =A0 =A0ports/databases/adstudio/Makefile
> =A01.43 =A0 =A0 =A0+4 -2 =A0 =A0 =A0ports/databases/adstudio/distinfo
>
- ${TAR} -C ${DATADIR} -xpf ${DISTDIR}/${_DISTFILES} \
+ # Extracting the base version:
+ ${TAR} -C ${DATADIR} -xpf ${DISTDIR}/${EXTRACT_ONLY} \
${INSTFILES:S|^|./datastudio/|}
This looks very fragile to me, since by definition EXTRACT_ONLY is a list.
It'd be better off wrapped in a .for, or use ${EXTRACT_ONLY:S/^/${DISTDIR}/=
}
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo839KPaf-9wqVEb8DcnSJHkq3318jV_dna44bprfKO92gvQ>