From owner-svn-src-all@freebsd.org  Mon Aug  3 18:20:17 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6B9499B27B6;
 Mon,  3 Aug 2015 18:20:17 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: from mail-qg0-x230.google.com (mail-qg0-x230.google.com
 [IPv6:2607:f8b0:400d:c04::230])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2A6E23A4;
 Mon,  3 Aug 2015 18:20:17 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: by qgeu79 with SMTP id u79so94854866qge.1;
 Mon, 03 Aug 2015 11:20:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=BuNH9DGv5VBTu+6CGaCfNu3DTUxH0pxCnvUsSNtkWY8=;
 b=uxiF+m0YFvZuF7C5AvdkNAe/OltHt9rydV0Gpf1kvGun/VOEuzqYAVyrSP6RQDuG+X
 U7UTtRk9je/hdR8RKJauKXs9ARaFLzg0BfzOWDDci7RMMJGs3/aJw3Lx7sriCZRwQdbv
 eyYJH36zOIBfveLsBRdGwjx2p0lfXjTp5iH+wUP8+q+U8ENI08gow4kg5NeCwF9oHmpR
 pke0wh2Ok5YdblbFqbqGDIB7IeA7J0NjAxcMF6ypFo8/qXtThFx9z1OKRPqth+/QBnGM
 S+1B9U33qa8qbzqr8tYj5CuBX5pjxidTNZfMkVALfhxehFLGPvdzp+eREw2zQ10ce6RZ
 JoSw==
MIME-Version: 1.0
X-Received: by 10.140.90.99 with SMTP id w90mr26474258qgd.57.1438626016326;
 Mon, 03 Aug 2015 11:20:16 -0700 (PDT)
Received: by 10.140.98.73 with HTTP; Mon, 3 Aug 2015 11:20:16 -0700 (PDT)
In-Reply-To: <55BFAAEB.2020900@FreeBSD.org>
References: <201508031627.t73GRbTB092225@repo.freebsd.org>
 <55BFAAEB.2020900@FreeBSD.org>
Date: Mon, 3 Aug 2015 11:20:16 -0700
Message-ID: <CAGHfRMDPqpDbPPdmcPXShF521_s5x=4uAdYhGiKPSD0SdMtmCQ@mail.gmail.com>
Subject: Re: svn commit: r286234 - head/sys/boot/common
From: NGie Cooper <yaneurabeya@gmail.com>
To: Andriy Gapon <avg@freebsd.org>
Cc: Edward Tomasz Napierala <trasz@freebsd.org>, 
 "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2015 18:20:17 -0000

On Mon, Aug 3, 2015 at 10:54 AM, Andriy Gapon <avg@freebsd.org> wrote:
> On 03/08/2015 19:27, Edward Tomasz Napierala wrote:
>> Author: trasz
>> Date: Mon Aug  3 16:27:36 2015
>> New Revision: 286234
>> URL: https://svnweb.freebsd.org/changeset/base/286234
>>
>> Log:
>>   Fix a problem which made loader(8) load non-kld files twice.
>
> What was the problem?
> The change looks like defensive coding, but it's not clear why the loader would
> attempt to load the same file more than once in the first place.
>
>>   For example, without this patch, the following three lines
>>   in /boot/loader.conf would result in /boot/root.img being preloaded
>>   twice, and two md(4) devices - md0 and md1 - being created.

Repro was something like this IIRC:

- Start module load.
- Hit a key to interrupt the boot so it drops into the loader prompt.
- Hit boot again.