From owner-svn-src-head@freebsd.org Tue Aug 30 00:01:22 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 81335BC7EB1; Tue, 30 Aug 2016 00:01:22 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from mail.strugglingcoder.info (strugglingcoder.info [104.236.146.68]) by mx1.freebsd.org (Postfix) with ESMTP id 70CAAA14; Tue, 30 Aug 2016 00:01:22 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from localhost (unknown [10.1.1.3]) (Authenticated sender: hiren@strugglingcoder.info) by mail.strugglingcoder.info (Postfix) with ESMTPA id 79A911735D; Mon, 29 Aug 2016 17:01:21 -0700 (PDT) Date: Mon, 29 Aug 2016 17:01:21 -0700 From: hiren panchasara To: Bruce Evans Cc: Bruce Evans , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r304895 - head/usr.bin/netstat Message-ID: <20160830000121.GD27495@strugglingcoder.info> References: <201608271106.u7RB669G009115@repo.freebsd.org> <20160828183439.GU41576@strugglingcoder.info> <20160829050500.D3932@besplex.bde.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="brEuL7wsLY8+TuWz" Content-Disposition: inline In-Reply-To: <20160829050500.D3932@besplex.bde.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2016 00:01:22 -0000 --brEuL7wsLY8+TuWz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 08/29/16 at 05:14P, Bruce Evans wrote: > On Sun, 28 Aug 2016, hiren panchasara wrote: >=20 > > On 08/27/16 at 11:06P, Bruce Evans wrote: > >> > >> Log: > >> Fix build without INET6 and with gcc. A function definition was ifd= efed > >> for INET6, but its protototype was not, and gcc detects the error. > >> > >> Modified: > >> head/usr.bin/netstat/route.c > > > > Thanks for the fix. > > > > Wouldn't stable/11 be broken in the same way? >=20 > Probably. >=20 > This only affects gcc users who omit INET6, and much more is broken for > stable/11 for gcc. Broken as in couldn't build? I don't think so. gcc + no-v6 seems like a special case but I think this should be fixed in 11. If you don't want to, I'll MFC the change myself. :-) Cheers, Hiren --brEuL7wsLY8+TuWz Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAABCgBmBQJXxMzOXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/liHIIAIP7chwqMqqLOln/4RVPoNON O0HvOAMaeX99s+Oz+aOdciO7PR4nTM9ThznCQFRo0mwHMUJC3mIVgv4UKmD3+CRn 2mlQq4a8h8IM+DkTieTocXeQPwfINUFlhCTSAuHhRC9JzRTZ+95AE7bcfRI9lAD7 Ss1BCHQru5NE/gD4DhFxQlkaCaBO0bTK/k4xhTnqdXLq6BlNh/oNW67dJjJkmkM5 R8lKY6Lfq6ssPdBUiY3UyAgEwb3NjRFptTdK0v/8gEzHiM64kHjOBsJplmW7JeJ4 Su/U3lq1R5f0XVepihfq1EL7VSiNxuHd4S+2JXY4YovWkuSY/ypRUz+w3f6iWJE= =aFAt -----END PGP SIGNATURE----- --brEuL7wsLY8+TuWz--