From owner-freebsd-bugs@FreeBSD.ORG  Mon Sep 13 07:10:31 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8BC2A16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 13 Sep 2004 07:10:31 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7C6F943D48
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 13 Sep 2004 07:10:31 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8D7AV29023643
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 13 Sep 2004 07:10:31 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8D7AVs6023642;
	Mon, 13 Sep 2004 07:10:31 GMT
	(envelope-from gnats)
Date: Mon, 13 Sep 2004 07:10:31 GMT
Message-Id: <200409130710.i8D7AVs6023642@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Dan Lukes <dan@obluda.cz>
Subject: Re: bin/71628: [PATCH] cleanup of the usr.sbin/rpcbind code
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Dan Lukes <dan@obluda.cz>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Sep 2004 07:10:31 -0000

The following reply was made to PR bin/71628; it has been noted by GNATS.

From: Dan Lukes <dan@obluda.cz>
To: Giorgos Keramidas <keramida@freebsd.org>
Cc: Dima Dorfman <dd@freebsd.org>, bug-followup@freebsd.org
Subject: Re: bin/71628: [PATCH] cleanup of the usr.sbin/rpcbind code
Date: Mon, 13 Sep 2004 09:02:41 +0200

 Giorgos Keramidas wrote:
 
 > That's a different thing.  Not using a variable isn't really dangerous.
 > Using the value of a pointer whose initial value contains garbage *is*
 > dangerous.
 
 	Unless you accidentally use "len" instead of "slen" which is totally
 diferent variable. Even "declared but newer used" warning may warn
 agains dangerous error within the code. It's the reason why any warning
 should be carefully evaluated (it's the reason we should eliminate
 warnings to already evaluated code)
 
 > I think a lot of the work in these patches is useful.  A few changes
 > here, a minor fix there and it'll be nice if they're committed and have
 > as many warnings fixed as possible.  This is my personal opinion though.
 
 	Well, I hope somebody commit it.
 
 > Keep up the good work ;-)
 
 	Thanks. And thanks for suggestions also.
 
 Dan