From owner-svn-src-all@freebsd.org Tue Jun 25 06:21:37 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A08A015C1D64 for ; Tue, 25 Jun 2019 06:21:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4366E735C3 for ; Tue, 25 Jun 2019 06:21:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x731.google.com with SMTP id r6so11719109qkc.0 for ; Mon, 24 Jun 2019 23:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vsLhbqy7eJX8FP/iZsR2j3KazmUDFMQz6SarA0qgVIY=; b=0jNp4WMPZ99Kp4AwMpWTvXhOTjc7eN/3XESzruGBmNP2YtsTwdF8JVLo/kW3SRe0RA Ug7AZJfaONscyyvy0+8Nn4azB7Bu1jqreJjthcjUKEcsnsxjdI1tps6D4HS/dHJ202WH qtwd0PLflwLItwDD2IhCmfCmiFW0EzijjPPwWK/ND1NWF0nc//NVcEJFuBQ/xK4eHuME c+9wL0RfryQYWHX0y0FeIYh7gzTcCC+aJdwWHk7+YeXQ6/lxTrE4o3Z5f4dZayNemBIq j3VdyI4SafAGMsdNnamPbvk5Gy5mXJpAuoP1/KJ8VDryfh6f0w8j9K8oqKh8RjekRV5t ttLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vsLhbqy7eJX8FP/iZsR2j3KazmUDFMQz6SarA0qgVIY=; b=rajhwL0qOzr792slpec0A8Upwu1+rdu/A1+ryX5UEqQOeWinP4Pn6M3ZvY7YunD2Vj avLzomPKYTIBuqmp2FxMEjrLzvBxJWL0nHw0kY21imm9Bqav9dS8jq8mCwl93gCXA41p YD4j/R7Fz76bPlt1Ybi/XpmIYUhr1/Qtkzh5wziDxGqPD4+xLGGNjqz5k4HVcX5qhULd gSf6rP5oI/1cPVzMExu0wWsAC8WCE4+Hn7OTj9iikfEPsujjRZBd+qrcBMFaDgyZh6je 8wZLdVeXgD0QzSMtKvYCAEUuJqcDIO3btHwiKX5B1pJyZZIe8IB6g/Kz+bEbjiGATIBk yxrw== X-Gm-Message-State: APjAAAWhUdG98ynWPlw2lQuH++z6+IrKPy7J21XNkl/pwfmmiZC0x2io PzXMTV3s44NFTEA2dyuBLLROElpWExXF+cY2imGXBoeyS+M= X-Google-Smtp-Source: APXvYqyMWeoYtcbouuAjPBRnow9L5ynJoDkYDb9T1Fv8Zup8wh1EsMyq9+430b/nueLIYnJPaDuZJ3eV7mR378b/U5c= X-Received: by 2002:a37:9307:: with SMTP id v7mr20323348qkd.495.1561443696209; Mon, 24 Jun 2019 23:21:36 -0700 (PDT) MIME-Version: 1.0 References: <201906250450.x5P4o9oR015946@repo.freebsd.org> In-Reply-To: <201906250450.x5P4o9oR015946@repo.freebsd.org> From: Warner Losh Date: Tue, 25 Jun 2019 00:21:25 -0600 Message-ID: Subject: Re: svn commit: r349352 - in head: etc/mtree include lib lib/libnandfs sbin sbin/camcontrol sbin/nandfs sbin/newfs_nandfs share/man/man4 share/man/man5 share/mk stand stand/arm/uboot stand/common stand... To: Warner Losh Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4366E735C3 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-7.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-1.00)[-0.996,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jun 2019 06:21:37 -0000 This commit accidentally reverted r349333, r349334, r349335, r349336, r349339, r349340, r349341 and r349342. I rebased after one of the make universes I did to proof this set and something must have gone wrong and I lost these changes. I noticed while committing, but didn't hit ^C fast enough to prevent the damage it seems. I've reapplied those changes rather than revert this commit for two reasons: first, reverting commits that delete things has caused me trouble in the past. Second, I judge that to be less repo-churn than doing the revert, then redoing the nand* removal. Time was of the essence, so I hope my snap-judgement was sound. My apologies both for the 'oops' and for any other fallout. Warner On Mon, Jun 24, 2019 at 10:50 PM Warner Losh wrote: > Author: imp > Date: Tue Jun 25 04:50:09 2019 > New Revision: 349352 > URL: https://svnweb.freebsd.org/changeset/base/349352 > > Log: > Remove NAND and NANDFS support > > NANDFS has been broken for years. Remove it. The NAND drivers that > remain are for ancient parts that are no longer relevant. They are > polled, have terrible performance and just for ancient arm > hardware. NAND parts have evolved significantly from this early work > and little to none of it would be relevant should someone need to > update to support raw nand. This code has been off by default for > years and has violated the vnode protocol leading to panics since it > was committed. > > Numerous posts to arch@ and other locations have found no actual users > for this software. > > Relnotes: Yes > No Objection From: arch@ > Differential Revision: https://reviews.freebsd.org/D20745 > ...