Date: Thu, 07 Sep 2023 19:51:27 +0000 From: bugzilla-noreply@freebsd.org To: chromium@FreeBSD.org Subject: [Bug 273625] www/chromium: use base iconv Message-ID: <bug-273625-28929@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273625 Bug ID: 273625 Summary: www/chromium: use base iconv Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: chromium@FreeBSD.org Reporter: gnikl@justmail.de Flags: maintainer-feedback?(chromium@FreeBSD.org) Assignee: chromium@FreeBSD.org The chromium build does ignore USES=3Diconv settings. If converters/libicon= v is installed the header ${LOCALBASE}/include/iconv.h is found before base icon= v.h. Since LIBICONV_PLUG defines from USES/iconv.mk do not affect the chromium b= uild system linking with -liconv was added in commit bfedd5f1f016c. Commit eb0137c80b62d enforced use of converters/libiconv by switching to iconv:wchar_t. However chromium builds successfully without libiconv instal= led when the modification of third_party/maldoca/BUILD.gn is removed. If base i= conv is sufficient for chromium, then third_party/maldoca/BUILD.gn should simply define LIBICONV_PLUG like this: -- cut -- --- third_party/maldoca/BUILD.gn~ 2022-11-20 12:40:52.000000000 +0100 +++ third_party/maldoca/BUILD.gn 2022-11-21 09:48:50.410589000 +0100 @@ -18,6 +18,9 @@ config("maldoca_flags") { config("maldoca_chromium_config") { defines =3D [ "MALDOCA_IN_CHROMIUM" ] + if (is_bsd) { + defines +=3D [ "LIBICONV_PLUG" ] + } } static_library("zlibwrapper") { -- cut -- Whether this approach works on OpenBSD, I do not know. It does work on Free= BSD. Maybe USES=3Diconv should removed completely since it does not work as inte= nded for chromium build. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-273625-28929>