From owner-svn-src-all@FreeBSD.ORG Mon Jul 29 19:14:37 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5B909979; Mon, 29 Jul 2013 19:14:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2B6BC29E2; Mon, 29 Jul 2013 19:14:37 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id A2CBBB948; Mon, 29 Jul 2013 15:14:35 -0400 (EDT) From: John Baldwin To: Sean Bruno Subject: Re: svn commit: r253708 - head/sys/dev/ipmi Date: Mon, 29 Jul 2013 10:54:55 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; ) References: <201307271632.r6RGWYF8046749@svn.freebsd.org> In-Reply-To: <201307271632.r6RGWYF8046749@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201307291054.55820.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 29 Jul 2013 15:14:35 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jul 2013 19:14:37 -0000 On Saturday, July 27, 2013 12:32:34 pm Sean Bruno wrote: > Author: sbruno > Date: Sat Jul 27 16:32:34 2013 > New Revision: 253708 > URL: http://svnweb.freebsd.org/changeset/base/253708 > > Log: > At some point after stable/7 the ACPI and ISA interfaces to the IPMI controller > no longer have the parent in the device tree. This causes the identify > function in ipmi_isa.c to attempt to probe and poke at the ISA IPMI interface They never had a common parent, even in 6.x and 7.x. > Move the check for ipmi_attached out of the ipmi_isa_attach function and into > the ipmi_isa_identify function. Remove the check of the device tree for > ipmi devices attached. > > This probing appears to make Broadcom management firmware on Dell machines > crash and emit NMI EISA warnings at various times requiring power cycles > of the machines to restore. This makes no sense. All you are doing is skipping ipmi_smbios_identify() which just looks at the SMBIOS table in RAM. It doesn't try to probe the BMC at all (no register accesses, etc.). If just reading a table in memory causes side effects, then running dmidecode in userland should be hosing your machines as well. -- John Baldwin