From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Mar 13 05:20:02 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0FE58106564A for ; Tue, 13 Mar 2012 05:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D40B28FC0C for ; Tue, 13 Mar 2012 05:20:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2D5K1FB098819 for ; Tue, 13 Mar 2012 05:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2D5K199098818; Tue, 13 Mar 2012 05:20:01 GMT (envelope-from gnats) Resent-Date: Tue, 13 Mar 2012 05:20:01 GMT Resent-Message-Id: <201203130520.q2D5K199098818@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Conrad J. Sabatier" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 27D5D1065670 for ; Tue, 13 Mar 2012 05:17:47 +0000 (UTC) (envelope-from conrads@serene.no-ip.org) Received: from eastrmfepo103.cox.net (eastrmfepo103.cox.net [68.230.241.215]) by mx1.freebsd.org (Postfix) with ESMTP id AE8A48FC0A for ; Tue, 13 Mar 2012 05:17:46 +0000 (UTC) Received: from eastrmimpo109.cox.net ([68.230.241.222]) by eastrmfepo103.cox.net (InterMail vM.8.01.04.00 201-2260-137-20101110) with ESMTP id <20120313051740.KDCJ8874.eastrmfepo103.cox.net@eastrmimpo109.cox.net> for ; Tue, 13 Mar 2012 01:17:40 -0400 Received: from serene.no-ip.org ([98.164.84.176]) by eastrmimpo109.cox.net with bizsmtp id ktHg1i0013oG0Ji02tHgYG; Tue, 13 Mar 2012 01:17:40 -0400 Received: from serene.no-ip.org (localhost [127.0.0.1]) by serene.no-ip.org (8.14.5/8.14.5) with ESMTP id q2D5Hdid068059 for ; Tue, 13 Mar 2012 00:17:39 -0500 (CDT) (envelope-from conrads@serene.no-ip.org) Received: (from root@localhost) by serene.no-ip.org (8.14.5/8.14.5/Submit) id q2D5HYIf068058; Tue, 13 Mar 2012 00:17:34 -0500 (CDT) (envelope-from conrads) Message-Id: <201203130517.q2D5HYIf068058@serene.no-ip.org> Date: Tue, 13 Mar 2012 00:17:34 -0500 (CDT) From: "Conrad J. Sabatier" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/165993: [patch] missorted SUBDIR in lang/Makefile X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Conrad J. Sabatier" List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2012 05:20:02 -0000 >Number: 165993 >Category: ports >Synopsis: [patch] missorted SUBDIR in lang/Makefile >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Mar 13 05:20:01 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Conrad J. Sabatier >Release: FreeBSD 10.0-CURRENT amd64 >Organization: >Environment: System: FreeBSD serene.no-ip.org 10.0-CURRENT FreeBSD 10.0-CURRENT #0: Sun Feb 12 19:15:46 CST 2012 conrads@serene.no-ip.org:/usr/obj/usr/src/sys/CUSTOM amd64 >Description: The item "perl5.8" is lexicographically greater than perl5.10, perl5.12 and perl5.14, and should follow, not precede them in the Makefile. I can understand how such a mistake could easily be made, if one is considering only the version numbers and mentally performing a numeric sort, but nonetheless, it should come after. My "mkreadmes" program helped me spot this, as it left several error messages in the log file from last night's ports tree update: Port lang/perl5.10 not found in INDEX Port lang/perl5.12 not found in INDEX Port lang/perl5.14 not found in INDEX Of course these are, in fact, in the index, but mkreadmes relies on having properly sorted Makefiles as part of its search optimization strategy. A missorted item will cause it to bypass other items that should have preceded it. >How-To-Repeat: N/A >Fix: patch below --- patch-ports-lang-Makefile begins here --- Index: ports/lang/Makefile =================================================================== RCS file: /home/ncvs/ports/lang/Makefile,v retrieving revision 1.768 diff -u -r1.768 Makefile --- ports/lang/Makefile 11 Mar 2012 23:52:40 -0000 1.768 +++ ports/lang/Makefile 13 Mar 2012 04:54:46 -0000 @@ -235,10 +235,10 @@ SUBDIR += pbasic SUBDIR += pcc SUBDIR += pecl-perl - SUBDIR += perl5.8 SUBDIR += perl5.10 SUBDIR += perl5.12 SUBDIR += perl5.14 + SUBDIR += perl5.8 SUBDIR += petite-chez SUBDIR += pfe SUBDIR += phantomjs --- patch-ports-lang-Makefile ends here --- >Release-Note: >Audit-Trail: >Unformatted: