From owner-svn-src-head@FreeBSD.ORG Sun Mar 22 14:38:52 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C8CD8A3E; Sun, 22 Mar 2015 14:38:52 +0000 (UTC) Received: from mail-pa0-x22e.google.com (mail-pa0-x22e.google.com [IPv6:2607:f8b0:400e:c03::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 961267F7; Sun, 22 Mar 2015 14:38:52 +0000 (UTC) Received: by pabxg6 with SMTP id xg6so150416514pab.0; Sun, 22 Mar 2015 07:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:references:to:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=9aEZRuf5xNtm23cU9oZU+Qrtv7CnQMdgYSDc7bTX6vw=; b=jFz+V+sRSPQwxmqAzKnQggDrnUCG5qreL7W5ZBX04urROTRr0IAGa80stNkbzj3uMG BWc5qAIuxE3jH6WYX1PybOlhvcTgnI7xeHWibv93GTprHi5cPcmusQpP+r5bgCd1pJim BcixyOvS4CTdsNqZbfIpvD/1+I1c0m8GzckMngTcJJTrb3fdRXFXrcMyNKTsg9vrVumK 3mOyr9lYRXMO1aV17GNxaFhtzXUOaVGVsX4PyrU7C5eCv8BABxsrI+Q0hVvfJrRi5Oi+ zYI6DCA1ZhNp3AZoD1UUtDnTiDIyT5TmHSNGiHYE4m4bBCwO/PIB5BcGq8OYXDAUE7XF 393Q== X-Received: by 10.66.102.34 with SMTP id fl2mr203192223pab.40.1427035132096; Sun, 22 Mar 2015 07:38:52 -0700 (PDT) Received: from [192.168.1.104] (ppp59-167-128-11.static.internode.on.net. [59.167.128.11]) by mx.google.com with ESMTPSA id j2sm14170097pdn.44.2015.03.22.07.38.49 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Mar 2015 07:38:51 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r280308 - head/sys/fs/devfs references: <201503210114.t2L1ECcB075556@svn.freebsd.org> <550D5D49.6020503@FreeBSD.org> <20150321142737.GJ2379@kib.kiev.ua> To: Konstantin Belousov From: Kubilay Kocak message-id: <550ED3F5.6040402@FreeBSD.org> Date: Mon, 23 Mar 2015 01:38:45 +1100 user-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Thunderbird/37.0 mime-version: 1.0 in-reply-to: <20150321142737.GJ2379@kib.kiev.ua> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 14:38:52 -0000 On 22/03/2015 1:27 AM, Konstantin Belousov wrote: > On Sat, Mar 21, 2015 at 11:00:09PM +1100, Kubilay Kocak wrote: >> On 21/03/2015 12:14 PM, Xin LI wrote: >>> Author: delphij >>> Date: Sat Mar 21 01:14:11 2015 >>> New Revision: 280308 >>> URL: https://svnweb.freebsd.org/changeset/base/280308 >>> >>> Log: >>> Disable timestamping on devfs read/write operations by default. >>> >>> Currently we update timestamps unconditionally when doing read or >>> write operations. This may slow things down on hardware where >>> reading timestamps is expensive (e.g. HPET, because of the default >>> vfs.timestamp_precision setting is nanosecond now) with limited >>> benefit. >>> >>> A new sysctl variable, vfs.devfs.dotimes is added, which can be >>> set to non-zero value when the old behavior is desirable. >> >> Perhaps *devfs_timestamp_update* is a better name. thoughts? >> >> If something shorter is desired: devfs_ts_update might be ok, though I >> prefer the former. >> >> Let's not forget these are user visible system control knobs, not just >> code variables, though I do understand the desire to shorten them, and >> that we do have descriptions for them ... mostly :) > > should it be > vfs.devfs.devfs_ts_devfs_ts_devfs_update_devfs > so that user is _absolutely_ sure that it is devfs related, if 'devfs' > used only one time in the MIB prevents him from realizing this ? > s/_/. devfs.timestamp_update sorry. :)