From owner-cvs-all Mon Mar 18 14:34: 1 2002 Delivered-To: cvs-all@freebsd.org Received: from rwcrmhc53.attbi.com (rwcrmhc53.attbi.com [204.127.198.39]) by hub.freebsd.org (Postfix) with ESMTP id 03B1C37B417; Mon, 18 Mar 2002 14:33:40 -0800 (PST) Received: from blossom.cjclark.org ([12.234.91.48]) by rwcrmhc53.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020318223339.NONG2951.rwcrmhc53.attbi.com@blossom.cjclark.org>; Mon, 18 Mar 2002 22:33:39 +0000 Received: (from cjc@localhost) by blossom.cjclark.org (8.11.6/8.11.6) id g2IMXcP60802; Mon, 18 Mar 2002 14:33:38 -0800 (PST) (envelope-from cjc) Date: Mon, 18 Mar 2002 14:33:38 -0800 From: "Crist J. Clark" To: "Jacques A. Vidrine" , Shin-ichi YOSHIMOTO , Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/chpass chpass.c pw_copy.c pw_copy.h Message-ID: <20020318143338.B60554@blossom.cjclark.org> Reply-To: cjclark@alum.mit.edu References: <200203180222.g2I2Ms309830@freefall.freebsd.org> <20020318161250.1c35600c.yosimoto@waishi.jp> <20020318170348.671ec4b5.yosimoto@waishi.jp> <20020318001922.Z29705@blossom.cjclark.org> <20020318212349.GA29060@madman.nectar.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020318212349.GA29060@madman.nectar.cc>; from nectar@FreeBSD.org on Mon, Mar 18, 2002 at 03:23:49PM -0600 X-URL: http://people.freebsd.org/~cjc/ Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Mar 18, 2002 at 03:23:49PM -0600, Jacques A. Vidrine wrote: > On Mon, Mar 18, 2002 at 12:19:22AM -0800, Crist J. Clark wrote: > > chpass(8) is very, very naughty and uses __pw_scan(). > > The underscores are a warning that it is being naughty. In this case, > I was not ready to commit to an API for `pw_scan', so when it needed > to be moved to libc, I hid it. I meant to revisit the issue one day, > but so it goes. > > Do not rename it unless you intend for it to be a public API that will > be maintained across releases. And don't forget to document it in > that case. Something else we can borrow from NetBSD. But I'm not sure if I like the way pw_scan() is split across libc and libutil with them. > [snip] > > This isn't an issue in -STABLE, where pw_scan() is exposed to the > > world properly in libc. > > No, it's not. There is no pw_scan in -STABLE's libc. Whoops. You're right, chpass(8) is getting it out of pwd_mkdb(8) in -STABLE. I probably was confusing our -STABLE implementation with NetBSD 1.5.x. -- Crist J. Clark | cjclark@alum.mit.edu | cjclark@jhu.edu http://people.freebsd.org/~cjc/ | cjc@freebsd.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message