From owner-cvs-all Tue Dec 11 9:26:34 2001 Delivered-To: cvs-all@freebsd.org Received: from tao.org.uk (genius.tao.org.uk [212.135.162.51]) by hub.freebsd.org (Postfix) with ESMTP id 7F04837BD33; Tue, 11 Dec 2001 09:15:24 -0800 (PST) Received: by tao.org.uk (Postfix, from userid 100) id 4817A33C; Tue, 11 Dec 2001 17:14:06 +0000 (GMT) Date: Tue, 11 Dec 2001 17:14:06 +0000 From: Josef Karthauser To: Alexey Zelkin Cc: Peter Wemm , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/gnu/usr.bin/binutils/gdb/i386 kvm-fbsd.c Message-ID: <20011211171406.C27214@tao.org.uk> References: <200112110704.fBB74mk31239@freefall.freebsd.org> <20011211164118.B27214@tao.org.uk> <20011211185847.A99187@ark.cris.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="raC6veAxrt5nqIoY" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011211185847.A99187@ark.cris.net>; from phantom@FreeBSD.org on Tue, Dec 11, 2001 at 06:58:47PM +0200 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --raC6veAxrt5nqIoY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 11, 2001 at 06:58:47PM +0200, Alexey Zelkin wrote: >=20 > > Is it worth having the commit fail if there's a null log message? >=20 > It could be useful as for me. But make sure that it should work correctly > in both pserver and local modes. In pserver mode it's not a problem to > check for null commit log and fail since all files are comiting at once, > but in local mode following scenario may exists: >=20 > . hack files in few directories > . do cvs commit > . write correct log for first directory files > . emptify log for second directory >=20 > in this case scripts will fail to continue and don't send email with > "(null)" content, but patches for first directory are already applied. > As result we have complete commit (at least part) and no notification > sent. No, I don't think that this is the case. By the time the CVSROOT scripts get the commit message cvs has already replaced the (null) log with the original message. =20 > PS: What about fix with current "$FreeBSD$ line mungled" CVSROOT problem ? > Bunch of patches from my tree awaiting to be commited! :) Tonight. I've got a patch, but haven't tested it yet. I only got back from Austria yesterday. Joe --raC6veAxrt5nqIoY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iEUEARECAAYFAjwWPt0ACgkQXVIcjOaxUBYtNgCYpHPV/ukqEjMA1W4sKP7MTE2D kwCfUgsSsPiGFIu+AqnHBE55RXddXcQ= =IZyj -----END PGP SIGNATURE----- --raC6veAxrt5nqIoY-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message