From nobody Tue Jul 8 19:16:57 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bc9pb6fjcz61P2X; Tue, 08 Jul 2025 19:17:11 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bc9pb3HGgz43Kv; Tue, 08 Jul 2025 19:17:11 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 568JGvY7064701; Tue, 8 Jul 2025 22:17:00 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 568JGvY7064701 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 568JGv6D064700; Tue, 8 Jul 2025 22:16:57 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 8 Jul 2025 22:16:57 +0300 From: Konstantin Belousov To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 01a679715f68 - main - err(3): print extended error if available Message-ID: References: <202507071928.567JSk8Y012639@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Rspamd-Queue-Id: 4bc9pb3HGgz43Kv X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] On Tue, Jul 08, 2025 at 03:09:32PM -0400, John Baldwin wrote: > On 7/7/25 15:28, Konstantin Belousov wrote: > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=01a679715f68d5e32efecafc1f158eecec3f781b > > > > commit 01a679715f68d5e32efecafc1f158eecec3f781b > > Author: Konstantin Belousov > > AuthorDate: 2025-06-16 21:26:22 +0000 > > Commit: Konstantin Belousov > > CommitDate: 2025-07-07 18:44:22 +0000 > > > > err(3): print extended error if available > > Reviewed by: asomers, brooks > > Sponsored by: The FreeBSD Foundation > > Differential revision: https://reviews.freebsd.org/D51141 > > It looks like this broke cross-building as all of the GitHub cross-build > actions are failing now after this commit, e.g.: > > https://github.com/freebsd/freebsd-src/actions/runs/16126095376/job/45503237749 > > /home/runner/work/freebsd-src/freebsd-src/lib/libc//gen/err.c:33:10: fatal error: sys/exterrvar.h: No such file or directory > 33 | #include > | ^~~~~~~~~~~~~~~~~ > compilation terminated. > --- err.o --- > *** [err.o] Error code 1 > > bmake[3]: stopped making "all" in /home/runner/work/freebsd-src/freebsd-src/tools/build > bmake[3]: 1 error > > bmake[3]: stopped making "all" in /home/runner/work/freebsd-src/freebsd-src/tools/build > --- legacy --- > *** [legacy] Error code 2 > > bmake[2]: stopped making "legacy" in /home/runner/work/freebsd-src/freebsd-src > bmake[2]: 1 error > > bmake[2]: stopped making "legacy" in /home/runner/work/freebsd-src/freebsd-src > Command exited with non-zero status 2 > 3.30user 0.79system 0:01.27elapsed 321%CPU (0avgtext+0avgdata 71296maxresident)k > 1200inputs+2984outputs (8major+109216minor)pagefaults 0swaps > --- _legacy --- > > bmake[1]: stopped making "kernel-toolchain" in /home/runner/work/freebsd-src/freebsd-src > --- kernel-toolchain --- > > bmake: stopped making "kernel-toolchain" in /home/runner/work/freebsd-src/freebsd-src > Error: Process completed with exit code 2. > > Presumably we are building a native libegacy on Linux that includes err.c, so we > need to either guard the new #include or add a compat header with > a stub implementation? I think that the guard would be not enough, the real compat header with some content like #define UEXTERROR_MAXLEN 128 static inline int uexterr_gettext(char *buf, size_t len) { if (len > 0) buf[0] = '\0'; return (0); } should work better.