From owner-svn-ports-head@freebsd.org Mon Jul 29 05:57:52 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ED1EFBE17B; Mon, 29 Jul 2019 05:57:52 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 90C798F985; Mon, 29 Jul 2019 05:57:52 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id EBEF7416; Mon, 29 Jul 2019 01:57:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 29 Jul 2019 01:57:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Aefp2q hfFDx96VvA/BOggUCXeacp2Q91H7tsuHhbTJ8=; b=LPwnm/hSx09jsMKzC/nqY1 SGkDCW99s+ak9EgJJaHElBZUBoh9Vxnq+xtzjWK5o9jXkdaEXCDmLrA1iiFl9J2X 2tN9P72gB+hwVAacekM43m2TaWq2Nv0vzDSOhflrotuTemVEDiCVTURLArl+xxf+ Ex8akrcuaPIfsnGBmyWJ1DBC+Q4t4IygV4YsCTZ2C6GEx6uPacgGVt54klzHxMDm NQp/465eHuHTOEBU9BvrchdPqT8v2UP9aGftKSQRCRfBozjAmxhxXlT4Yyg7ZkHg QrtFihVaL1nahzfagzx2bswX8ME4TdHTW0qa5ZodPZeDJJyhu25RDNylkE7qomrg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrledtgddutdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujggfsehgtd erredtredvnecuhfhrohhmpefvohgsihgrshcumfhorhhtkhgrmhhpuceothhosghikhes fhhrvggvsghsugdrohhrgheqnecuffhomhgrihhnpehfrhgvvggsshgurdhorhhgnecukf hppeelhedrledtrddvvdeirdeikeenucfrrghrrghmpehmrghilhhfrhhomhepthhosghi khesfhhrvggvsghsugdrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from urd.tobik.me (ip5f5ae244.dynamic.kabel-deutschland.de [95.90.226.68]) by mail.messagingengine.com (Postfix) with ESMTPA id 8B087380079; Mon, 29 Jul 2019 01:57:43 -0400 (EDT) Date: Mon, 29 Jul 2019 07:57:41 +0200 From: Tobias Kortkamp To: Gleb Popov Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r507361 - head/Mk/Uses Message-ID: <20190729055741.GA35501@urd.tobik.me> References: <201907261652.x6QGqoxC018196@repo.freebsd.org> <20190727055121.GA99138@urd.tobik.me> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 90C798F985 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.97 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.99)[-0.994,0]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; ASN(0.00)[asn:11403, ipnet:64.147.123.0/24, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jul 2019 05:57:53 -0000 --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 28, 2019 at 02:19:30PM +0400, Gleb Popov wrote: > On Sat, Jul 27, 2019 at 9:51 AM Tobias Kortkamp wrote: >=20 > > On Fri, Jul 26, 2019 at 04:52:50PM +0000, Gleb Popov wrote: > > > Author: arrowd > > > Date: Fri Jul 26 16:52:49 2019 > > > New Revision: 507361 > > > URL: https://svnweb.freebsd.org/changeset/ports/507361 > > > > > > Log: > > > Add support for USES=3D cabal:hpack and document this option. > > > > > > Modified: > > > head/Mk/Uses/cabal.mk > > > > > > Modified: head/Mk/Uses/cabal.mk > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- head/Mk/Uses/cabal.mk Fri Jul 26 16:46:46 2019 (r50736= 0) > > > +++ head/Mk/Uses/cabal.mk Fri Jul 26 16:52:49 2019 (r50736= 1) > > > @@ -2,9 +2,13 @@ > > > # > > > # Provide support for building Haskell packages using Cabal. > > > # > > > -# Feature: cabal > > > -# Usage: USES=3Dcabal > > > +# Feature: cabal > > > +# Usage: USES=3Dcabal or USES=3Dcabal:ARGS > > > +# Valid ARGS: hpack > > > # > > > +# hpack: The port doesn't have a .cabal file and needs > > devel/hs-hpack to > > > +# generate it from package.yaml file > > > +# > > > # Variables, which can be set by the port: > > > # > > > # USE_CABAL List of Haskell packages required to build a po= rt. > > > @@ -36,10 +40,6 @@ > > > .if !defined(_INCLUDE_USES_CABAL_MK) > > > _INCLUDE_USES_CABAL_MK=3D yes > > > > > > -.if !empty(cabal_ARGS) > > > -IGNORE=3D Incorrect 'USES=3D cabal:${cabal_ARGS}' cabal= takes > > no arguments > > > -.endif > > > - > > > > Nothing checks USES=3Dcabal args now and it accepts any garbage > > arguments like USES=3Dcabal:asdfasd. Please put back some check for > > invalid arguments. > > >=20 > Does https://svnweb.freebsd.org/changeset/ports/507506 look good for you? It's ok. Thanks. The error message could be better though. It flags 'hpack' as invalid with something like USES=3Dcabal:hpack,foo "USES=3Dcabal: invalid arguments: hpack foo" 'hpack' is not an invalid argument here, only 'foo' is. --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl0+itBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2Fh5wgAspWgd1EKCJq6RMs4hXTOlA7hd0gos5miDD6e74nWdghrNo61VGaobv0T GZDR5R+XUJQ4NsOUZP42cdECtpzPb6bFyX4fu1SGVkesyVkK5uy2wPrguCwwerb1 aO/MnJTUcS23vJoOvwdNO6IFmds6pWkWuXCHpXWQqrj5dEL6QcG+b5DW8+yPbq09 zwCRcl9EiEQ3E09PnUBH/G0g4hifCzoDW54bovOG3qIWO8fKJgTsljo+c+dlU0mW R809tpqpQUPFNRJkWuX40HVoc006ou38jeXvdwK1/5Tp/0zYPClvIt2JTe/mxody HaZ6H2ZFCDBcjDVdb81hjXmZ5S4RjQ== =NoCe -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--