Date: Tue, 4 Dec 2012 23:56:21 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: freebsd-hackers@freebsd.org Subject: Re: naming a .h file for kernel use only Message-ID: <20121204215621.GT3013@kib.kiev.ua> In-Reply-To: <1019659624.1136294.1354652917707.JavaMail.root@erie.cs.uoguelph.ca> References: <1019659624.1136294.1354652917707.JavaMail.root@erie.cs.uoguelph.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
--sOuRR0jXHR3ukxKL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 04, 2012 at 03:28:37PM -0500, Rick Macklem wrote: > Hi, >=20 > For my NFSv4.1 client work, I've taken a few definitions out of a > kernel rpc .c file and put them in a .h file so that they can > be included in other sys/rpc .c files. >=20 > I've currently named the file _krpc.h. I thought I'd check if > this is a reasonable name before doing the "big commit" of the > NFSv4.1 stuff to head. (I have a vague notion that a leading "_" > would indicate "not for public use", but I am not sure?) >=20 > Thanks in advance for naming suggestions for this file, rick I believe that _thing.h is the convention for the headers that are never directly included by the .c files. It is there to hide some shared parts of other includes, for consumption by includes. Why not move the stuff to sys/nfs/krpc.h ? BTW, this file lacks the include guards. --sOuRR0jXHR3ukxKL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJQvnGFAAoJEJDCuSvBvK1BrxQP/j+U6AWYSjkiph6Gj+rCkF0N SICY09jqfgRO4U9x4+MAdeX7M1HjJxGSroZDw2N0LH9m6ooQDjLmmyA1fKM2IZpb aRGXMrgP1I2KBNc0MyQaJBZwClZlpXcNboDRIxKSyF8DvNgUo4DbMEbBkvdLYi3X VEmlNTPS43NFlgc/qYwqFZ94cuGGtV85aSDU3ZGDLE/fHtl+9WCmfkt5e4ieDx0R LBDIAKKeouDPRKKqMca37OAiJ09y7EQoUoHf1Vj0wNoUNUxFgca41m93aQJkBfpO dNXQb2Cg8m21nM8QniOGLZ6lU9/3/Rpk2zB4DR/RBGGxEr7EAcOLMBSX9qguOOhC WGp9gBodkMzwjlAqQ03fCTXjMZnt0PRjoO7yLDhRdxb2W/TjKgGxUoQPjWwQ0XJp jCG6CtA4fm6zcrjm4fjLHzWDqU7um7gLMZSizYuXw9r3zJ8K1W0Hr8Pyg9bKRozs um0/isqRGTYIirAaE0Yt7t/TUPFuI8YI7MEYeqB2LlwvnOFMxNe/1TyrQI5Po/CQ EBVjO5UXufbxh+XTRLiBYjyvdRSONxr7EbUf/Wth65xQKhs0axZ1nv958QT++lgk sT4yBF+sLAa43dNVVt4eVCrKu/RPT2TzDOkOpMp1tpjcCN3Z2GGcZVFOJnQ2Fpe7 FqZSHj10w60v8+6L1s5u =5eBN -----END PGP SIGNATURE----- --sOuRR0jXHR3ukxKL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121204215621.GT3013>