From owner-freebsd-hackers@FreeBSD.ORG Tue Dec 4 21:56:26 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 76760353 for ; Tue, 4 Dec 2012 21:56:26 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id D38338FC0C for ; Tue, 4 Dec 2012 21:56:25 +0000 (UTC) Received: from tom.home (localhost [127.0.0.1]) by kib.kiev.ua (8.14.5/8.14.5) with ESMTP id qB4LuMih025313; Tue, 4 Dec 2012 23:56:22 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.7.1 kib.kiev.ua qB4LuMih025313 Received: (from kostik@localhost) by tom.home (8.14.5/8.14.5/Submit) id qB4LuLod025312; Tue, 4 Dec 2012 23:56:21 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 4 Dec 2012 23:56:21 +0200 From: Konstantin Belousov To: Rick Macklem Subject: Re: naming a .h file for kernel use only Message-ID: <20121204215621.GT3013@kib.kiev.ua> References: <1019659624.1136294.1354652917707.JavaMail.root@erie.cs.uoguelph.ca> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sOuRR0jXHR3ukxKL" Content-Disposition: inline In-Reply-To: <1019659624.1136294.1354652917707.JavaMail.root@erie.cs.uoguelph.ca> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: freebsd-hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2012 21:56:26 -0000 --sOuRR0jXHR3ukxKL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 04, 2012 at 03:28:37PM -0500, Rick Macklem wrote: > Hi, >=20 > For my NFSv4.1 client work, I've taken a few definitions out of a > kernel rpc .c file and put them in a .h file so that they can > be included in other sys/rpc .c files. >=20 > I've currently named the file _krpc.h. I thought I'd check if > this is a reasonable name before doing the "big commit" of the > NFSv4.1 stuff to head. (I have a vague notion that a leading "_" > would indicate "not for public use", but I am not sure?) >=20 > Thanks in advance for naming suggestions for this file, rick I believe that _thing.h is the convention for the headers that are never directly included by the .c files. It is there to hide some shared parts of other includes, for consumption by includes. Why not move the stuff to sys/nfs/krpc.h ? BTW, this file lacks the include guards. --sOuRR0jXHR3ukxKL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJQvnGFAAoJEJDCuSvBvK1BrxQP/j+U6AWYSjkiph6Gj+rCkF0N SICY09jqfgRO4U9x4+MAdeX7M1HjJxGSroZDw2N0LH9m6ooQDjLmmyA1fKM2IZpb aRGXMrgP1I2KBNc0MyQaJBZwClZlpXcNboDRIxKSyF8DvNgUo4DbMEbBkvdLYi3X VEmlNTPS43NFlgc/qYwqFZ94cuGGtV85aSDU3ZGDLE/fHtl+9WCmfkt5e4ieDx0R LBDIAKKeouDPRKKqMca37OAiJ09y7EQoUoHf1Vj0wNoUNUxFgca41m93aQJkBfpO dNXQb2Cg8m21nM8QniOGLZ6lU9/3/Rpk2zB4DR/RBGGxEr7EAcOLMBSX9qguOOhC WGp9gBodkMzwjlAqQ03fCTXjMZnt0PRjoO7yLDhRdxb2W/TjKgGxUoQPjWwQ0XJp jCG6CtA4fm6zcrjm4fjLHzWDqU7um7gLMZSizYuXw9r3zJ8K1W0Hr8Pyg9bKRozs um0/isqRGTYIirAaE0Yt7t/TUPFuI8YI7MEYeqB2LlwvnOFMxNe/1TyrQI5Po/CQ EBVjO5UXufbxh+XTRLiBYjyvdRSONxr7EbUf/Wth65xQKhs0axZ1nv958QT++lgk sT4yBF+sLAa43dNVVt4eVCrKu/RPT2TzDOkOpMp1tpjcCN3Z2GGcZVFOJnQ2Fpe7 FqZSHj10w60v8+6L1s5u =5eBN -----END PGP SIGNATURE----- --sOuRR0jXHR3ukxKL--