From owner-freebsd-audit  Mon Jun 25 14: 8:56 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138])
	by hub.freebsd.org (Postfix) with ESMTP id B894D37B40B
	for <audit@FreeBSD.org>; Mon, 25 Jun 2001 14:08:49 -0700 (PDT)
	(envelope-from dima@unixfreak.org)
Received: from hornet.unixfreak.org (hornet [63.198.170.140])
	by bazooka.unixfreak.org (Postfix) with ESMTP
	id 304673E28; Mon, 25 Jun 2001 14:08:00 -0700 (PDT)
To: Mike Barcroft <mike@q9media.com>
Cc: audit@FreeBSD.org
Subject: Re: src/usr.sbin/fdcontrol patch 
In-Reply-To: <200106250515.f5P5FXo91684@coffee.q9media.com>; from mike@q9media.com on "Mon, 25 Jun 2001 01:15:33 -0400 (EDT)"
Date: Mon, 25 Jun 2001 14:08:00 -0700
From: Dima Dorfman <dima@unixfreak.org>
Message-Id: <20010625210800.304673E28@bazooka.unixfreak.org>
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

Mike Barcroft <mike@q9media.com> writes:
> I would appreciate it if someone would review and commit the patch at
> the end of this message.  Also available at:
> http://testbed.q9media.net/freebsd/fdcontrol.20010625.patch
> 
> 
> Best regards,
> Mike Barcroft
> 
> -----------------------------------------------------------------------
> 
> fdcontrol.20010625.patch
> 
> o Make two functions static to silence compiler warnings

I think the right thing to do here would be to add prototypes.

> o Clean up the Makefile a little and set WARNS?=2
> 
> 
> Index: fdcontrol/Makefile
> ===================================================================
> RCS file: /home/ncvs/src/usr.sbin/fdcontrol/Makefile,v
> retrieving revision 1.3
> diff -u -r1.3 Makefile
> --- fdcontrol/Makefile	2001/03/26 14:40:02	1.3
> +++ fdcontrol/Makefile	2001/06/25 04:58:06
> @@ -1,6 +1,7 @@
>  # $FreeBSD: src/usr.sbin/fdcontrol/Makefile,v 1.3 2001/03/26 14:40:02 ru Exp
>  $
>  
> -PROG = fdcontrol
> -MAN = fdcontrol.8
> +PROG=	fdcontrol
> +WARNS?=	2
> +MAN=	fdcontrol.8
>  
>  .include <bsd.prog.mk>
> Index: fdcontrol/fdcontrol.c
> ===================================================================
> RCS file: /home/ncvs/src/usr.sbin/fdcontrol/fdcontrol.c,v
> retrieving revision 1.7
> diff -u -r1.7 fdcontrol.c
> --- fdcontrol/fdcontrol.c	2001/06/06 06:16:12	1.7
> +++ fdcontrol/fdcontrol.c	2001/06/25 04:58:06
> @@ -37,7 +37,7 @@
>  #include <sys/file.h>
>  #include <sys/fdcio.h>
>  
> -int
> +static int
>  getnumber(void)
>  {
>    int i;
> @@ -50,7 +50,7 @@
>    return i;
>  }
>  
> -void
> +static void
>  usage(void)
>  {
>    fprintf(stderr, "usage: fdcontrol [-d 0|1] | [-s] device-node\n");
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-audit" in the body of the message
> 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message