From owner-freebsd-ports@FreeBSD.ORG Mon Dec 20 19:50:19 2010 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD7851065673; Mon, 20 Dec 2010 19:50:19 +0000 (UTC) (envelope-from ponomarew@gmail.com) Received: from mail-ey0-f178.google.com (mail-ey0-f178.google.com [209.85.215.178]) by mx1.freebsd.org (Postfix) with ESMTP id 052838FC19; Mon, 20 Dec 2010 19:50:18 +0000 (UTC) Received: by eyh5 with SMTP id 5so1393732eyh.37 for ; Mon, 20 Dec 2010 11:50:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:mime-version :content-type:from:in-reply-to:date:cc:message-id:references:to :x-mailer; bh=V/Yi9gs+g0YSDgjS3V4nfhb4a5j7QXqUbWCVy6PqXhU=; b=oX0XWvZnFMEDwIo31VwqbcOtD3moVTf1mlK4dflYJmhwcA2BD6EFD7Tww/lvpF84lG zTqpPq84ZjNjY5Mz9bJ3WBMl3Ge7oX3FoNtp6tlSQpGNvjIxvevyL8J0PWYjL9ERWDOp INIkFQjK2WLBsUl8W5fRpk6wJWmtG2jBgNupY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to:x-mailer; b=GfGQA1xQJpKlZ/pvokUC9fWO8kK1Ih2FS/rdx6fcRbIWUiWrWhxQ+J4OwBdGxTC9eg LTbBzzi3uO6KzK8uNbY0Zj/eXl8Tn4JTzodrKwNtRaxxBnJOutqG6bA0h/+BK675A9a8 yNgkX4TD/LpBDSzRU2i1L8+a7tvPhY0PlHMuw= Received: by 10.14.119.7 with SMTP id m7mr3042282eeh.9.1292873211310; Mon, 20 Dec 2010 11:26:51 -0800 (PST) Received: from [192.168.1.50] ([79.164.130.32]) by mx.google.com with ESMTPS id t5sm3107909eeh.14.2010.12.20.11.26.48 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 20 Dec 2010 11:26:49 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v1082) From: Kirill Ponomarev In-Reply-To: <4D0CDA89.1040506@FreeBSD.org> Date: Mon, 20 Dec 2010 22:26:45 +0300 Message-Id: References: <4D0CDA89.1040506@FreeBSD.org> To: ohauer@FreeBSD.org X-Mailer: Apple Mail (2.1082) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: ports@freebsd.org, Mark Murray Subject: Re: Exim port tidyup. X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Dec 2010 19:50:20 -0000 On Dec 18, 2010, at 7:00 PM, Olli Hauer wrote: > On 2010-12-18 15:10, Mark Murray wrote: >> Hi >>=20 >> I've done a bit of maintenance on a port that I originally wrote, = Exim. >>=20 >> I redid the patches by using the "make makepatch" target (it makes = doing >> maintainance easier, as the patch names are regularised and you get = to >> see diffs easier). >>=20 >> As part of this, there is a minor change to the way Exim works, which = is >> a security feature, due to be default in future Exim releases. In the >> EDITME file, it is ALT_CONFIG_ROOT_ONLY, and if its OK to commit this >> cleanup, then I'd commit that separately. >>=20 >> Is it ok for me to commit this please? >>=20 >> http://people.freebsd.org/~markm/exim.tar.gz >>=20 >> ... and it is straight out of my ports/mail/exim/... tree, with >> CVS/... files intact and ready to go, except that I'd do the >> ALT_CONFIG_ROOT_ONLY bit separately. >>=20 >> M >=20 >=20 > Hi Mark, >=20 > since the old patch-files have a long history I suggest open a > change-request PR to repocopy the files and assign the PR to portmgr. >=20 > If portmgr has done the repocopy you can remove the old patch files > and apply your diff (the only significant change I see is in = src__EDITME) >=20 > Things I miss in your diff > - bump PORTREVISION? (if more than EDITME change) > - remove MD5 from distinfo >=20 > Isn't it easier to remove the targets > o show-options-list > o show-variables-list > from Makefile.options and use only the code from the file options = directly? I fully agree here, repocopy is needed first, before we start renaming = patches. K.