From owner-freebsd-stable@freebsd.org Mon Jul 13 08:36:33 2015 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1835F99BC82 for ; Mon, 13 Jul 2015 08:36:33 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wg0-x22c.google.com (mail-wg0-x22c.google.com [IPv6:2a00:1450:400c:c00::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A39751A98 for ; Mon, 13 Jul 2015 08:36:32 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wgkl9 with SMTP id l9so19870373wgk.1 for ; Mon, 13 Jul 2015 01:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=TC47GhrKqjqxx1AleNotm/Z/zIb0wa+nk5kePa97ufM=; b=oIWKfoe56q8haGFhJAlg8Mx2FFkkguh/DmopWPJNS738csK4A0KD32kKMo06ls7SGm /D8dw+86c/2MPT58kULbt08tNGs4fo5pDh1GI/+ir+cT9p4RSTgflVNgF80R3pAiHlSJ uzUHcw5XesE6CEEd4iV5cq5KwWQb1mAnxat5xQ4O4qZQvadxHYuWp97YE/oz4lmVIC5G dKo6H1503iXIY9Tnjw15HicV7AZIc+QMr077W3dMf9r8nUdfmtgOzRxnTMJO8focER24 rVngSKgrKmCq0Cy2kEGJVGU0ts9TrvEJAPSHfsxp2uyNH7A7vKBUnVIAEqU6a9aha49p q0JQ== X-Received: by 10.180.75.78 with SMTP id a14mr21610770wiw.68.1436776591083; Mon, 13 Jul 2015 01:36:31 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id d7sm13291157wij.0.2015.07.13.01.36.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jul 2015 01:36:30 -0700 (PDT) Sender: Baptiste Daroussin Date: Mon, 13 Jul 2015 10:36:28 +0200 From: Baptiste Daroussin To: Jan Mikkelsen Cc: FreeBSD Stable Mailing List Subject: Re: 10.2-BETA1: pw(8) does not support "pw useradd name -u 0" Message-ID: <20150713083628.GA37597@ivaldir.etoilebsd.net> References: <00BBEBAC-D7E2-4312-995B-93F7F0EDDD42@transactionware.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HlL+5n6rz5pIUxbD" Content-Disposition: inline In-Reply-To: <00BBEBAC-D7E2-4312-995B-93F7F0EDDD42@transactionware.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2015 08:36:33 -0000 --HlL+5n6rz5pIUxbD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 13, 2015 at 04:57:32PM +1000, Jan Mikkelsen wrote: > Hi, >=20 > In our system build scripts we have this command: >=20 > /usr/sbin/pw -V $d useradd toor -u 0 -g 0 -d /root -s /bin/sh -c "Bourne-= again Superuser" -g wheel -o >=20 > After 10.2-BETA1, the toor account is being added with UID 1001 instead o= f UID 0. This looks like a problem with line 754 in pw_user.c, which has th= is test: >=20 > /* > * Check the given uid, if any > */ > if (id > 0) { > uid =3D (uid_t) id; >=20 > if ((pwd =3D GETPWUID(uid)) !=3D NULL && conf.checkduplic= ate) > errx(EX_DATAERR, "uid `%u' has already been alloc= ated", pwd->pw_uid); > } else { > struct bitmap bm; >=20 >=20 > The (id > 0) test should probably be (id >=3D 0) to allow =E2=80=9C-u 0= =E2=80=9D to be passed on the command line. >=20 > This change is from r285092 by bapt@. Was this change in behaviour intent= ional? Nope, I'll fix asap Thanks for reporting Best regards, Bapt --HlL+5n6rz5pIUxbD Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlWjeIwACgkQ8kTtMUmk6ExPHQCeJEVB1w5N/1POLy5KzbyD8jnG ljIAoIDz/2L2J1dj1aqwUXW5CEFPk6tU =dMJh -----END PGP SIGNATURE----- --HlL+5n6rz5pIUxbD--