From owner-freebsd-current@FreeBSD.ORG Wed Jan 28 22:07:36 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AEF351065680; Wed, 28 Jan 2009 22:07:36 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (77-93-215-190.static.masterinter.net [77.93.215.190]) by mx1.freebsd.org (Postfix) with ESMTP id 5FA3F8FC1D; Wed, 28 Jan 2009 22:07:35 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 77E7D9CB07C; Wed, 28 Jan 2009 23:05:06 +0100 (CET) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (lev.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z8ShJ13RFD12; Wed, 28 Jan 2009 23:04:55 +0100 (CET) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id DADCD9CB0EC; Wed, 28 Jan 2009 23:04:54 +0100 (CET) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.14.3/8.14.3/Submit) id n0SM4s0G067494; Wed, 28 Jan 2009 23:04:54 +0100 (CET) (envelope-from rdivacky) Date: Wed, 28 Jan 2009 23:04:54 +0100 From: Roman Divacky To: John Baldwin Message-ID: <20090128220454.GA66961@freebsd.org> References: <20090128193318.GA42071@freebsd.org> <200901281521.17674.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200901281521.17674.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: freebsd-current@freebsd.org, scottl@freebsd.org Subject: Re: sysctl question X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2009 22:07:37 -0000 On Wed, Jan 28, 2009 at 03:21:17PM -0500, John Baldwin wrote: > On Wednesday 28 January 2009 2:33:18 pm Roman Divacky wrote: > > hi > > > > we dont need Giant to be held for sysctl_ctx_init/SYSCTL_ADD_*, right? > > Ugh, it looks like the sysctl tree locking is woefully inadequate, so we > aren't quite ready for this yet. what do you mean? should all sysctl_ctx_init/SYSCTL_ADD_* consumers lock Giant? I didnt not find a single one (except the scsi stuff) that locks it... can you explain? thnx roman