From owner-svn-src-head@FreeBSD.ORG Wed Apr 27 03:00:27 2011 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E6C21065673; Wed, 27 Apr 2011 03:00:27 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from mail.icecube.wisc.edu (trout.icecube.wisc.edu [128.104.255.119]) by mx1.freebsd.org (Postfix) with ESMTP id 3B8008FC15; Wed, 27 Apr 2011 03:00:21 +0000 (UTC) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.icecube.wisc.edu (Postfix) with ESMTP id 26EF058134; Tue, 26 Apr 2011 22:00:21 -0500 (CDT) X-Virus-Scanned: amavisd-new at icecube.wisc.edu Received: from mail.icecube.wisc.edu ([127.0.0.1]) by localhost (trout.icecube.wisc.edu [127.0.0.1]) (amavisd-new, port 10030) with ESMTP id oh9+6SRQviPB; Tue, 26 Apr 2011 22:00:21 -0500 (CDT) Received: from wanderer.tachypleus.net (unknown [76.210.65.155]) by mail.icecube.wisc.edu (Postfix) with ESMTP id 3F3D65811E; Tue, 26 Apr 2011 22:00:20 -0500 (CDT) Message-ID: <4DB786C3.3010607@freebsd.org> Date: Tue, 26 Apr 2011 22:00:19 -0500 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.15) Gecko/20110317 Thunderbird/3.1.9 MIME-Version: 1.0 To: Daniel O'Connor References: <201104240923.p3O9N8QG025386@svn.freebsd.org> <20110424161933.GA18775@vniz.net> <18B3AE1E-467E-4B23-81B9-AB1EDEFE1F7A@gsoft.com.au> <34A34338-79E0-435E-9BF1-614D10FC9FC7@gsoft.com.au> <15C958E3-6CF7-48C4-88C9-2E61AC301657@gsoft.com.au> In-Reply-To: <15C958E3-6CF7-48C4-88C9-2E61AC301657@gsoft.com.au> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: src-committers@FreeBSD.org, Andrey Chernov , Alexander Motin , svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Warner Losh Subject: Re: svn commit: r220983 - head X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2011 03:00:27 -0000 On 04/26/11 18:48, Daniel O'Connor wrote: > > On 26/04/2011, at 1:31, Warner Losh wrote: >>> This is why I prefer IDs since they are nominally unique (UFS >>> ones, GPTs damn well better be :) >>> >>> Although I concede it is rather annoying to work out which is >>> which, or type them out manually.. >> >> For things like ZFS, UUIDs aren't so bad because it hides them. > > Yes, I use GPT with ZFS, it's good :) > >> For things like /etc/fstab, I prefer the named approach. This >> allows me to survive a newfs on a partition if I have to without >> having to hack my /etc/fstab. I have a large /tmp partition at >> times, and it gets newfs'd if there's a bad problem... > > Yeah, but.. IMHO if the installer supports it then it is dramatically > less painful.. > > I haven't looked to see how hard it is to add, hopefully I will get > some time to look RSN and it shouldn't be too difficult. It's not difficult to add -- the issue is that the mechanism is unreliable. It doesn't work for all partition types supporting labels, it's hard to figure out what the name of the label provider is in a generic way, and the label providers have a nasty habit of disappearing periodically when you use the underlying provider for anything. Also, retastes don't always work. For example, if I change the label of a GPT partition, the label provider does not reflect the change until a disk reattach (e.g. a reboot). If it's a feature that we enable by default, and that the installer relies upon, it has to work better than that. -Nathan