From nobody Tue Feb 1 00:03:58 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5F7E4198CED5 for ; Tue, 1 Feb 2022 00:03:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JnlXG0L3Xz3np5 for ; Tue, 1 Feb 2022 00:03:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E04F025F06 for ; Tue, 1 Feb 2022 00:03:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 21103vVs028862 for ; Tue, 1 Feb 2022 00:03:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 21103v0A028861 for bugs@FreeBSD.org; Tue, 1 Feb 2022 00:03:57 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 261566] Padding of DLT_PFLOG packets should be done differently Date: Tue, 01 Feb 2022 00:03:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: gharris@sonic.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643673838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QhpK9iAdtUIQqXwpRv487QwEtMQKjtp1ish7wkjji/I=; b=JxDfmLMEK1ThbLUJGfIv/xNQhs/PDjxt5R0wGfJefNDnueDx9zf7bI3e29WlLF2mjurkHR WPGawRIk5/KAweRdVlRldU9q2iSfjpNk5qRg0ORMcBlBWvtelD8+mExiP/ChYI9GyeFvPf xT18jR7sHkxSGrvzhDY4AAKFBWp1RnPs3VkcB0ItoNTpX3b1ALvJ3bS5s5bXVX3R0oU5Mj SSHkCXwF5c8DoKms1DEWtZeXZEllIhCG7Il/NZAcoI5KqddLiEcrir/w0UsLzzzUZ9EFQr QmeBdRQf90UgjRBtWi4kHQVm0VFGNG/MBI2ktNx+uIF6ifESXfCWVk8fxA/CMA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1643673838; a=rsa-sha256; cv=none; b=YJqC5T/9W1oF3F/9N6c0/J2H9FiCB8bJQbxdLoWAz9ATkYFK1OggZiuT2R68OdCKxQX0Eo 4Ke/QTWVExpwXHw5tx7K75fgdpxOjr/oGT4J3iOiEBvXH+RgzHYSm2H+XVId6E1SuasiCd KW/DQO1r7/rx9AUc4Z4H9O3gOzPdDPHle7mY2FEaqk6alLFAiHuy/rZZWVF+N9pE95OL8S ecijq7Zxr/TKWbKzjggo0ZF8iPh0EkSX7VbwvFyFr9OrplPTl89Y6DmKA7AUeIMuigEVfy cquyZKzjOdfh6imE4p8mwsENN9WcRVjI8PrK6cVKVYCEqihMiakwOkUMpIllEQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261566 --- Comment #3 from Guy Harris --- > I distinctly recall looking at the Wireshark code before implementing the= BPF_WORDALIGN(), however it clearly does `padded_length =3D WS_ROUNDUP_4(l= ength);`, so I don't know what happened there. It got fixed from "add 3 to the length under the assumption that there's 1 = byte of padding" to "round it up to a multiple of 4". (Tcpdump now does the same thing, and libpcap now gets the pflog header len= gth from the length field, rounding it up to a multiple of 4, rather than havin= g a hardwired length based on whatever platform it was compiled on.) > How does this look to you: That should work. --=20 You are receiving this mail because: You are the assignee for the bug.=