From owner-p4-projects@FreeBSD.ORG Thu Apr 22 23:09:15 2004 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 4EEBC16A4D0; Thu, 22 Apr 2004 23:09:15 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1DD2016A4CE for ; Thu, 22 Apr 2004 23:09:15 -0700 (PDT) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id A4CC743D58 for ; Thu, 22 Apr 2004 23:09:14 -0700 (PDT) (envelope-from marcel@xcllnt.net) Received: from dhcp01.pn.xcllnt.net (dhcp01.pn.xcllnt.net [192.168.4.201]) by ns1.xcllnt.net (8.12.11/8.12.11) with ESMTP id i3N692jH011057; Thu, 22 Apr 2004 23:09:02 -0700 (PDT) (envelope-from marcel@piii.pn.xcllnt.net) Received: from dhcp01.pn.xcllnt.net (localhost [127.0.0.1]) i3N6926p019068; Thu, 22 Apr 2004 23:09:02 -0700 (PDT) (envelope-from marcel@dhcp01.pn.xcllnt.net) Received: (from marcel@localhost) by dhcp01.pn.xcllnt.net (8.12.11/8.12.11/Submit) id i3N692rk019067; Thu, 22 Apr 2004 23:09:02 -0700 (PDT) (envelope-from marcel) Date: Thu, 22 Apr 2004 23:09:02 -0700 From: Marcel Moolenaar To: "M. Warner Losh" Message-ID: <20040423060902.GA19060@dhcp01.pn.xcllnt.net> References: <200404230321.i3N3LxhW010292@repoman.freebsd.org> <20040422.233350.119859738.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040422.233350.119859738.imp@bsdimp.com> User-Agent: Mutt/1.4.2.1i cc: perforce@freebsd.org Subject: Re: PERFORCE change 51597 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Apr 2004 06:09:16 -0000 On Thu, Apr 22, 2004 at 11:33:50PM -0600, M. Warner Losh wrote: > : ==== //depot/projects/gdb/sys/dev/pci/pci.c#7 (text+ko) ==== > : > : @@ -825,6 +825,12 @@ > : if (base == 0) > : return 1; > : > : + /* Sun EBus bridges contain the ranges for the devices beyond them */ > : + if ((pci_get_class(dev) == PCIC_BRIDGE) && > : + (pci_get_vendor(dev) == 0x108e) && > : + (pci_get_device(dev) == 0x1000 || pci_get_device(dev) == 0x1100)) > : + return 1; > : + > : start = base; > : end = base + (1 << ln2size) - 1; > : count = 1 << ln2size; > > Shouldn't the ebus bridge device be allocating the resources and > giving them to their children? This isn't the right fix and I'd like > to work with you to the fix at the right level... Yes. tmm@ is working on that. I want to see the stopgap fix committed in the mean time to unbreak sparc64. I'm waiting to hear back from tmm@. Don't worry. The above change is not a solution. It's a quick fix to give us some breathing room. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net