From owner-svn-ports-head@FreeBSD.ORG Fri Apr 5 12:48:28 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1317) id 335002F5; Fri, 5 Apr 2013 12:48:28 +0000 (UTC) Date: Fri, 5 Apr 2013 12:48:28 +0000 From: William Grzybowski To: Max Brazhnikov Subject: Re: svn commit: r315222 - in head: devel/qdevelop games/warmux graphics/xaos math/qtiplot multimedia/minitube print/hplip textproc/qstardict Message-ID: <20130405124828.GA92713@hub.freebsd.org> References: <201303251359.r2PDxIXf035701@svn.freebsd.org> <33299091.KSdYOtgceu@mercury.ph.man.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33299091.KSdYOtgceu@mercury.ph.man.ac.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , Eitan Adler , svn-ports-all@freebsd.org, ports-committers , Sunpoet Po-Chuan Hsieh X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2013 12:48:28 -0000 On Fri, Apr 05, 2013 at 12:40:07PM +0000, Max Brazhnikov wrote: > On Thu, 04 Apr 2013 17:24:32 +0800 Sunpoet Po-Chuan Hsieh wrote: > > I think these options can be used globally and also per port. These options > > are just on by default via bsd.options.mk. Users should be able to turn > > them off through options dialog while building/installing specific port. I > > think it has higher possibility that one user wants to install > > documentation/examples of *some ports but not all ports*. As a result, we > > should keep those options. At least we shall not always hide them. > > > > If maintainers think these options are annoying, they could put them to the > > end of OPTIONS_DEFINE. > > We don't disagree about DOCS/NSL/etc options, when a ports already defines > other options. The question is should these options be in OPTIONS_DEFINE > if they are the only options provided by the port (read: allow option dialog > to pop up with trivial option set for virtually every port)? Sorry to jump in this thread. But what about change .mk to do not issue a make config if OPTIONS_DEFINE is only consisted of global options? Someone could manually run make config if wanted to. I agree it would be very annoying let it pop up for every trivial port. > > On Thu, Mar 28, 2013 at 10:57 AM, Eitan Adler wrote: > > > > > On 27 March 2013 22:53, Alexey Dokuchaev wrote: > > > > On Mon, Mar 25, 2013 at 01:59:18PM +0000, Max Brazhnikov wrote: > > > >> New Revision: 315222 > > > >> URL: http://svnweb.freebsd.org/changeset/ports/315222 > > > >> > > > >> - Remove OPTIONS_DEFINE, if it contains only global options > > > > > > > > Can you elaborate on this one? Given that there is no clear policy, > > > > personally I've been always including OPTIONS_DEFINE, even if just for, > > > say, > > > > DOCS. > > > > > > Options such as IPV6, DOCS, EXAMPLES, and NLS are generally set > > > globally (e.g., OPTIONS_UNSET= NLS) and not per port. As such, it can > > > reduce user annoyance if the dialog box is not shown for such options. > > > > > > > > > > > > -- > > > Eitan Adler > > > Source, Ports, Doc committer > > > Bugmeister, Ports Security teams > > >